Chromium Code Reviews| Index: chrome/browser/resources/settings/people_page/lock_screen_constants.js |
| diff --git a/chrome/browser/resources/settings/people_page/lock_screen_constants.js b/chrome/browser/resources/settings/people_page/lock_screen_constants.js |
| index 2fc1ad4c64e200c17ff85d50400937ea1203edb7..41d606dcf95efb33fac628cc9b9621cecc06144f 100644 |
| --- a/chrome/browser/resources/settings/people_page/lock_screen_constants.js |
| +++ b/chrome/browser/resources/settings/people_page/lock_screen_constants.js |
| @@ -31,17 +31,17 @@ cr.define('settings', function() { |
| * histogram. |
| * @param {LockScreenProgress} currentProgress |
| */ |
|
dschuyler
2017/04/19 18:58:41
Also missed the comment indent (I assume related t
dpapad
2017/04/19 19:19:55
Yes, that is the same issue mentioned before.
|
| -var recordLockScreenProgress = function(currentProgress) { |
| - if (currentProgress >= LockScreenProgress.MAX_BUCKET) { |
| - console.error('Expected a enumeration value of ' + |
| + var recordLockScreenProgress = function(currentProgress) { |
| + if (currentProgress >= LockScreenProgress.MAX_BUCKET) { |
| + console.error('Expected a enumeration value of ' + |
| LockScreenProgress.MAX_BUCKET + ' or lower: Received ' + |
| currentProgress + '.'); |
| - return; |
| - } |
| - chrome.send('metricsHandler:recordInHistogram', |
| + return; |
| + } |
| + chrome.send('metricsHandler:recordInHistogram', |
| [PinUnlockUmaHistogramName, currentProgress, |
| - LockScreenProgress.MAX_BUCKET]); |
| -}; |
| + LockScreenProgress.MAX_BUCKET]); |
| + }; |
| return { |
| recordLockScreenProgress: recordLockScreenProgress |