MD Settings: ESLint --fix output, WIP.

chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js

Index: chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
index ca60421a8af5ab38aa74b3548242434bacfdc9ed..607b3545fc2ef1765c85a8ca3be33fbd11434402 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js
@@ -3,25 +3,25 @@
 // found in the LICENSE file.
 
 (function() {
-  'use strict';
+'use strict';
 
   /**
    * This is the absolute difference maintained between standard and
    * fixed-width font sizes. http://crbug.com/91922.
    * @const @private {number}
    */

[dpapad, 2017/04/19 17:48:22]

OuterIIFEBody indentation fix. Unfortunately --fix is currently not re-indenting
the comments properly. I filed https://github.com/eslint/eslint/issues/8478, and
it seems that this is addressed in the next version (ESLint 4, which is
currently in alhpa).

[Dan Beam, 2017/04/19 19:04:40]

we'd definitely need that to use eslint, IMO...

-  var SIZE_DIFFERENCE_FIXED_STANDARD_ = 3;
+var SIZE_DIFFERENCE_FIXED_STANDARD_ = 3;
 
   /** @const @private {!Array<number>} */
-  var FONT_SIZE_RANGE_ = [
-    9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 20, 22, 24, 26, 28, 30, 32, 34, 36,
-    40, 44, 48, 56, 64, 72,
-  ];
+var FONT_SIZE_RANGE_ = [
+  9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 20, 22, 24, 26, 28, 30, 32, 34, 36,
+  40, 44, 48, 56, 64, 72,
+];
 
   /** @const @private {!Array<number>} */
-  var MINIMUM_FONT_SIZE_RANGE_ = [
-    6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 20, 22, 24
-  ];
+var MINIMUM_FONT_SIZE_RANGE_ = [
+  6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 20, 22, 24
+];
 
   /**
    * 'settings-appearance-fonts-page' is the settings page containing appearance
@@ -32,137 +32,137 @@
    *   <settings-appearance-fonts-page prefs="{{prefs}}">
    *   </settings-appearance-fonts-page>
    */
-  Polymer({
-    is: 'settings-appearance-fonts-page',
+Polymer({
+  is: 'settings-appearance-fonts-page',
 
-    behaviors: [I18nBehavior, WebUIListenerBehavior],
+  behaviors: [I18nBehavior, WebUIListenerBehavior],
 
-    properties: {
+  properties: {
       /** @private */
-      advancedExtensionSublabel_: String,
+    advancedExtensionSublabel_: String,
 
       /** @private {!DropdownMenuOptionList} */
-      fontOptions_: Object,
+    fontOptions_: Object,
 
       /** @private */
-      isGuest_: {
-        type: Boolean,
-        value: function() { return loadTimeData.getBoolean('isGuest'); }
-      },
+    isGuest_: {
+      type: Boolean,
+      value: function() { return loadTimeData.getBoolean('isGuest'); }
+    },
 
       /**
        * Common font sizes.
        * @private {!Array<number>}
        */
-      fontSizeRange_: {
-        readOnly: true,
-        type: Array,
-        value: FONT_SIZE_RANGE_,
-      },
+    fontSizeRange_: {
+      readOnly: true,
+      type: Array,
+      value: FONT_SIZE_RANGE_,
+    },
 
       /**
        * Reasonable, minimum font sizes.
        * @private {!Array<number>}
        */
-      minimumFontSizeRange_: {
-        readOnly: true,
-        type: Array,
-        value: MINIMUM_FONT_SIZE_RANGE_,
-      },
+    minimumFontSizeRange_: {
+      readOnly: true,
+      type: Array,
+      value: MINIMUM_FONT_SIZE_RANGE_,
+    },
 
       /**
        * Preferences state.
        */
-      prefs: {
-        type: Object,
-        notify: true,
-      },
+    prefs: {
+      type: Object,
+      notify: true,
     },
+  },
 
     /** @private {?settings.FontsBrowserProxy} */
-    browserProxy_: null,
+  browserProxy_: null,
 
     /** @private {boolean} */
-    advancedExtensionInstalled_: false,
+  advancedExtensionInstalled_: false,
 
     /** @private {?string} */
-    advancedExtensionUrl_: null,
+  advancedExtensionUrl_: null,
 
-    observers: [
-      'fontSizeChanged_(prefs.webkit.webprefs.default_font_size.value)',
-    ],
+  observers: [
+    'fontSizeChanged_(prefs.webkit.webprefs.default_font_size.value)',
+  ],
 
     /** @override */
-    created: function() {
-      this.browserProxy_ = settings.FontsBrowserProxyImpl.getInstance();
-    },
+  created: function() {
+    this.browserProxy_ = settings.FontsBrowserProxyImpl.getInstance();
+  },
 
     /** @override */
-    ready: function() {
-      this.addWebUIListener('advanced-font-settings-installed',
+  ready: function() {
+    this.addWebUIListener('advanced-font-settings-installed',
           this.setAdvancedExtensionInstalled_.bind(this));
-      this.browserProxy_.observeAdvancedFontExtensionAvailable();
+    this.browserProxy_.observeAdvancedFontExtensionAvailable();
 
-      this.browserProxy_.fetchFontsData().then(
+    this.browserProxy_.fetchFontsData().then(
           this.setFontsData_.bind(this));
-    },
+  },
 
     /** @private */
-    openAdvancedExtension_: function() {
-      if (this.advancedExtensionInstalled_)
-        this.browserProxy_.openAdvancedFontSettings();
-      else
+  openAdvancedExtension_: function() {
+    if (this.advancedExtensionInstalled_)
+      this.browserProxy_.openAdvancedFontSettings();
+    else
         window.open(this.advancedExtensionUrl_);
-    },
+  },
 
     /**
      * @param {boolean} isInstalled Whether the advanced font settings
      *     extension is installed.
      * @private
      */
-    setAdvancedExtensionInstalled_: function(isInstalled) {
-      this.advancedExtensionInstalled_ = isInstalled;
-      this.advancedExtensionSublabel_ = this.i18n(isInstalled ?
+  setAdvancedExtensionInstalled_: function(isInstalled) {
+    this.advancedExtensionInstalled_ = isInstalled;
+    this.advancedExtensionSublabel_ = this.i18n(isInstalled ?
           'openAdvancedFontSettings' : 'requiresWebStoreExtension');
-    },
+  },
 
     /**
      * @param {!FontsData} response A list of fonts and the advanced
      *     font settings extension URL.
      * @private
      */
-    setFontsData_: function(response) {
-      var fontMenuOptions = [];
-      for (var i = 0; i < response.fontList.length; ++i) {
-        fontMenuOptions.push({
-          value: response.fontList[i][0],
-          name: response.fontList[i][1]
-        });
-      }
-      this.fontOptions_ = fontMenuOptions;
-      this.advancedExtensionUrl_ = response.extensionUrl;
-    },
+  setFontsData_: function(response) {
+    var fontMenuOptions = [];
+    for (var i = 0; i < response.fontList.length; ++i) {
+      fontMenuOptions.push({
+        value: response.fontList[i][0],
+        name: response.fontList[i][1]
+      });
+    }
+    this.fontOptions_ = fontMenuOptions;
+    this.advancedExtensionUrl_ = response.extensionUrl;
+  },
 
     /**
      * @param {number} value The changed font size slider value.
      * @private
      */
-    fontSizeChanged_: function(value) {
+  fontSizeChanged_: function(value) {
       // TODO(michaelpg): Whitelist this pref in prefs_utils.cc so it is
       // included in the <settings-prefs> getAllPrefs call, otherwise this path
       // is invalid and nothing happens. See crbug.com/612535.
-      this.set('prefs.webkit.webprefs.default_fixed_font_size.value',
+    this.set('prefs.webkit.webprefs.default_fixed_font_size.value',
           value - SIZE_DIFFERENCE_FIXED_STANDARD_);
-    },
+  },
 
     /**
      * Get the minimum font size, accounting for unset prefs.
      * @return {?}
      * @private
      */
-    computeMinimumFontSize_: function() {
-      return this.get('prefs.webkit.webprefs.minimum_font_size.value') ||
+  computeMinimumFontSize_: function() {
+    return this.get('prefs.webkit.webprefs.minimum_font_size.value') ||
           MINIMUM_FONT_SIZE_RANGE_[0];
-    },
-  });
+  },
+});
 })();