MD Settings: ESLint --fix output, WIP.

chrome/browser/resources/settings/route.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /**
    * Class for navigable routes. May only be instantiated within this file.
    * @constructor
    * @param {string} path
    * @private
@@ skipping 271 matching lines @@
    */
   var getRouteForPath = function(path) {
     // Allow trailing slash in paths.
     var canonicalPath = path.replace(CANONICAL_PATH_REGEX, '$1$2');
 
     // TODO(tommycli): Use Object.values once Closure compilation supports it.
     var matchingKey = Object.keys(Route).find(function(key) {
       return Route[key].path == canonicalPath;
     });
 
-    return !!matchingKey ? Route[matchingKey] : null;

[dpapad, 2017/04/19 17:48:22]

http://eslint.org/docs/rules/no-extra-boolean-cast fix. We can turn that off if
not desired.

[Dan Beam, 2017/04/19 19:04:40]

compiler will whine in some cases

[dpapad, 2017/05/05 18:20:46]

Done, turned this off for now.

+    return matchingKey ? Route[matchingKey] : null;
   };
 
   /**
    * The current active route. This updated is only by settings.navigateTo or
    * settings.initializeRouteFromUrl.
    * @private {!settings.Route}
    */
   var currentRoute_ = Route.BASIC;
 
   /**
@@ skipping 123 matching lines @@
     getRouteForPath: getRouteForPath,
     initializeRouteFromUrl: initializeRouteFromUrl,
     resetRouteForTesting: resetRouteForTesting,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
     lastRouteChangeWasPopstate: lastRouteChangeWasPopstate,
     navigateTo: navigateTo,
     navigateToPreviousRoute: navigateToPreviousRoute,
   };
 });