Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_printers.js

Issue 2834433002: MD Settings: ESLint --fix output, WIP. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-cups-printers' is a component for showing CUPS 6 * @fileoverview 'settings-cups-printers' is a component for showing CUPS
7 * Printer settings subpage (chrome://md-settings/cupsPrinters). It is used to 7 * Printer settings subpage (chrome://md-settings/cupsPrinters). It is used to
8 * set up legacy & non-CloudPrint printers on ChromeOS by leveraging CUPS (the 8 * set up legacy & non-CloudPrint printers on ChromeOS by leveraging CUPS (the
9 * unix printing system) and the many open source drivers built for CUPS. 9 * unix printing system) and the many open source drivers built for CUPS.
10 */ 10 */
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 chrome.networkingPrivate.onNetworksChanged.removeListener( 54 chrome.networkingPrivate.onNetworksChanged.removeListener(
55 this.networksChangedListener_); 55 this.networksChangedListener_);
56 }, 56 },
57 57
58 /** 58 /**
59 * Callback function when networks change. 59 * Callback function when networks change.
60 * @private 60 * @private
61 */ 61 */
62 refreshNetworks_: function() { 62 refreshNetworks_: function() {
63 chrome.networkingPrivate.getNetworks( 63 chrome.networkingPrivate.getNetworks(
64 {'networkType': chrome.networkingPrivate.NetworkType.ALL, 64 {'networkType': chrome.networkingPrivate.NetworkType.ALL,
dschuyler 2017/04/19 18:58:41 This should be a four space indent I believe.
Dan Beam 2017/04/19 19:07:03 yeah, i think this goes against our style guide
dpapad 2017/04/19 19:19:55 This is configurable, see http://eslint.org/docs/r
65 'configured': true}, 65 'configured': true},
66 this.onNetworksReceived_.bind(this)); 66 this.onNetworksReceived_.bind(this));
67 }, 67 },
68 68
69 /** 69 /**
70 * Callback function when configured networks are received. 70 * Callback function when configured networks are received.
71 * @param {!Array<!chrome.networkingPrivate.NetworkStateProperties>} states 71 * @param {!Array<!chrome.networkingPrivate.NetworkStateProperties>} states
72 * A list of network state information for each network. 72 * A list of network state information for each network.
73 * @private 73 * @private
74 */ 74 */
75 onNetworksReceived_: function(states) { 75 onNetworksReceived_: function(states) {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 onAddPrinterTap_: function() { 117 onAddPrinterTap_: function() {
118 this.$.addPrinterDialog.open(); 118 this.$.addPrinterDialog.open();
119 this.$.addPrinterErrorMessage.hidden = true; 119 this.$.addPrinterErrorMessage.hidden = true;
120 }, 120 },
121 121
122 /** @private */ 122 /** @private */
123 onAddPrinterDialogClose_: function() { 123 onAddPrinterDialogClose_: function() {
124 this.$$('#addPrinter').focus(); 124 this.$$('#addPrinter').focus();
125 }, 125 },
126 }); 126 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698