Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 /** | 5 /** |
| 6 * @fileoverview Constants used for logging the pin unlock setup uma. | 6 * @fileoverview Constants used for logging the pin unlock setup uma. |
| 7 */ | 7 */ |
| 8 | 8 |
| 9 /** | 9 /** |
| 10 * Name of the pin unlock setup uma histogram. | 10 * Name of the pin unlock setup uma histogram. |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 23 ENTER_PIN: 3, | 23 ENTER_PIN: 3, |
| 24 CONFIRM_PIN: 4, | 24 CONFIRM_PIN: 4, |
| 25 MAX_BUCKET: 5 | 25 MAX_BUCKET: 5 |
| 26 }; | 26 }; |
| 27 | 27 |
| 28 cr.define('settings', function() { | 28 cr.define('settings', function() { |
| 29 /** | 29 /** |
| 30 * Helper function to send the progress of the pin setup to be recorded in the | 30 * Helper function to send the progress of the pin setup to be recorded in the |
| 31 * histogram. | 31 * histogram. |
| 32 * @param {LockScreenProgress} currentProgress | 32 * @param {LockScreenProgress} currentProgress |
| 33 */ | 33 */ |
|
dschuyler
2017/04/19 18:58:41
Also missed the comment indent (I assume related t
dpapad
2017/04/19 19:19:55
Yes, that is the same issue mentioned before.
| |
| 34 var recordLockScreenProgress = function(currentProgress) { | 34 var recordLockScreenProgress = function(currentProgress) { |
| 35 if (currentProgress >= LockScreenProgress.MAX_BUCKET) { | 35 if (currentProgress >= LockScreenProgress.MAX_BUCKET) { |
| 36 console.error('Expected a enumeration value of ' + | 36 console.error('Expected a enumeration value of ' + |
| 37 LockScreenProgress.MAX_BUCKET + ' or lower: Received ' + | 37 LockScreenProgress.MAX_BUCKET + ' or lower: Received ' + |
| 38 currentProgress + '.'); | 38 currentProgress + '.'); |
| 39 return; | 39 return; |
| 40 } | 40 } |
| 41 chrome.send('metricsHandler:recordInHistogram', | 41 chrome.send('metricsHandler:recordInHistogram', |
| 42 [PinUnlockUmaHistogramName, currentProgress, | 42 [PinUnlockUmaHistogramName, currentProgress, |
| 43 LockScreenProgress.MAX_BUCKET]); | 43 LockScreenProgress.MAX_BUCKET]); |
| 44 }; | 44 }; |
| 45 | 45 |
| 46 return { | 46 return { |
| 47 recordLockScreenProgress: recordLockScreenProgress | 47 recordLockScreenProgress: recordLockScreenProgress |
| 48 }; | 48 }; |
| 49 }); | 49 }); |
| OLD | NEW |