Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 /** | 5 /** |
| 6 * @fileoverview | 6 * @fileoverview |
| 7 * 'settings-internet-page' is the settings page containing internet | 7 * 'settings-internet-page' is the settings page containing internet |
| 8 * settings. | 8 * settings. |
| 9 */ | 9 */ |
| 10 Polymer({ | 10 Polymer({ |
| (...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 272 * vpnProviders | 272 * vpnProviders |
| 273 * @param {!chrome.management.ExtensionInfo} extension | 273 * @param {!chrome.management.ExtensionInfo} extension |
| 274 * @private | 274 * @private |
| 275 */ | 275 */ |
| 276 addVpnProvider_: function(vpnProviders, extension) { | 276 addVpnProvider_: function(vpnProviders, extension) { |
| 277 if (!extension.enabled || | 277 if (!extension.enabled || |
| 278 extension.permissions.indexOf('vpnProvider') == -1) { | 278 extension.permissions.indexOf('vpnProvider') == -1) { |
| 279 return; | 279 return; |
| 280 } | 280 } |
| 281 if (vpnProviders.find(function(provider) { | 281 if (vpnProviders.find(function(provider) { |
| 282 return provider.ExtensionID == extension.id; | 282 return provider.ExtensionID == extension.id; |
| 283 })) { | 283 })) { |
|
dschuyler
2017/04/19 18:58:41
The body of the |if| now appears to be dangling.
Dan Beam
2017/04/19 19:07:03
yeah, i think the previous one was better. i thin
dpapad
2017/04/19 19:19:54
This is also configurable. Specifically see http:/
| |
| 284 return; | 284 return; |
| 285 } | 285 } |
| 286 var newProvider = { | 286 var newProvider = { |
| 287 ExtensionID: extension.id, | 287 ExtensionID: extension.id, |
| 288 ProviderName: extension.name, | 288 ProviderName: extension.name, |
| 289 }; | 289 }; |
| 290 vpnProviders.push(newProvider); | 290 vpnProviders.push(newProvider); |
| 291 }, | 291 }, |
| 292 | 292 |
| 293 /** | 293 /** |
| (...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 342 }, | 342 }, |
| 343 | 343 |
| 344 /** | 344 /** |
| 345 * @param {!chrome.networkingPrivate.ThirdPartyVPNProperties} provider | 345 * @param {!chrome.networkingPrivate.ThirdPartyVPNProperties} provider |
| 346 * @return {string} | 346 * @return {string} |
| 347 */ | 347 */ |
| 348 getAddThirdParrtyVpnLabel_: function(provider) { | 348 getAddThirdParrtyVpnLabel_: function(provider) { |
| 349 return this.i18n('internetAddThirdPartyVPN', provider.ProviderName); | 349 return this.i18n('internetAddThirdPartyVPN', provider.ProviderName); |
| 350 } | 350 } |
| 351 }); | 351 }); |
| OLD | NEW |