Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 283443003: AppListTestViewDelegate::ShouldCenterWindow returns the proper value. (Closed)

Created:
6 years, 7 months ago by Matt Giuca
Modified:
6 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

AppListTestViewDelegate::ShouldCenterWindow returns the proper value. Previously, AppListControllerTest's "centered" tests were actually testing the non-centered app list mode (due to an uncaught semantic merge conflict between SVN 268479 and 269208). Now the centered tests run the app list in centered mode. BUG=372268 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269769

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/app_list/test/app_list_test_view_delegate.cc View 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
Matt Giuca
https://codereview.chromium.org/283443003/diff/1/ui/app_list/test/app_list_test_view_delegate.cc File ui/app_list/test/app_list_test_view_delegate.cc (right): https://codereview.chromium.org/283443003/diff/1/ui/app_list/test/app_list_test_view_delegate.cc#newcode134 ui/app_list/test/app_list_test_view_delegate.cc:134: return app_list::switches::IsCenteredAppListEnabled(); Note: To understand what this is doing, ...
6 years, 7 months ago (2014-05-12 06:30:37 UTC) #1
benwells
lgtm
6 years, 7 months ago (2014-05-12 07:00:16 UTC) #2
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 7 months ago (2014-05-12 07:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/283443003/1
6 years, 7 months ago (2014-05-12 07:03:37 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 11:50:53 UTC) #5
Message was sent while issue was closed.
Change committed as 269769

Powered by Google App Engine
This is Rietveld 408576698