Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2834393003: Re-enable ScrollbarAnimationController::DidRequestShowFromMainThread. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index d17602cb1561833fc7adc76b38648b3f4074b35e..02375ead5fc1cce685b2b67cd1d2671d260e908b 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -1668,7 +1668,12 @@ void FrameView::ViewportSizeChanged(bool width_changed, bool height_changed) {
}
}
+// TODO(skobes): For reasons not fully understood, showing scrollbars from
+// main on viewport size changes regresses memory and perf tests on Android
aelias_OOO_until_Jul13 2017/04/25 21:05:08 Hmm, since you traced it to viewport sized changes
+// (crbug.com/706927, crbug.com/712453).
+#if !OS(ANDROID)
aelias_OOO_until_Jul13 2017/04/25 21:05:08 I really don't like OS(ANDROID), among other thing
ShowOverlayScrollbars();
+#endif
if (root_layer_scrolling_enabled) {
// The background must be repainted when the FrameView is resized, even if
« no previous file with comments | « cc/input/scrollbar_animation_controller.cc ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698