Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.idl

Issue 283423005: Use Promises for screen.lockOrientation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/screen_orientation/ScreenOrientation.idl
diff --git a/Source/modules/screen_orientation/ScreenOrientation.idl b/Source/modules/screen_orientation/ScreenOrientation.idl
index 310a07b69bcef8ff71409757c0d82d2f4f4942f9..caddb8570eb076641952446b0888dd99415f796b 100644
--- a/Source/modules/screen_orientation/ScreenOrientation.idl
+++ b/Source/modules/screen_orientation/ScreenOrientation.idl
@@ -24,7 +24,7 @@ enum OrientationLockType {
] partial interface Screen {
readonly attribute OrientationType orientation;
- [RaisesException] boolean lockOrientation(OrientationLockType orientation);
+ [CallWith=ExecutionContext] Promise lockOrientation(OrientationLockType orientation);
void unlockOrientation();
};

Powered by Google App Engine
This is Rietveld 408576698