Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: public/platform/Platform.h

Issue 283423005: Use Promises for screen.lockOrientation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/Platform.h
diff --git a/public/platform/Platform.h b/public/platform/Platform.h
index f2e79d66c03d00877a3b1b66682f1ed50092274a..11ab36e3708f5b2923c0760525fa1e038ddf5c6b 100644
--- a/public/platform/Platform.h
+++ b/public/platform/Platform.h
@@ -36,13 +36,16 @@
#endif
#include "WebAudioDevice.h"
+#include "WebCallbacks.h"
#include "WebCommon.h"
+#include "WebDOMException.h"
#include "WebData.h"
#include "WebGamepadListener.h"
#include "WebGamepads.h"
#include "WebGraphicsContext3D.h"
#include "WebLocalizedString.h"
#include "WebScreenOrientationLockType.h"
+#include "WebScreenOrientationType.h"
#include "WebSpeechSynthesizer.h"
#include "WebStorageQuotaCallbacks.h"
#include "WebStorageQuotaType.h"
@@ -632,8 +635,16 @@ public:
// Screen Orientation -------------------------------------------------
+ typedef WebCallbacks<blink::WebScreenOrientationType, blink::WebDOMException> WebLockOrientationCallback;
virtual void setScreenOrientationListener(blink::WebScreenOrientationListener*) { }
virtual void lockOrientation(WebScreenOrientationLockType) { }
+ // Request a screen orientation lock and pass a |callback| object to be used
+ // to notify of success/failure. The |callback| parameter is expected to be
+ // owned by the implementation.
+ virtual void lockOrientation(WebScreenOrientationLockType, WebLockOrientationCallback* callback)
+ {
+ delete callback; // prevents memory leak if there is no implementation.
+ }
virtual void unlockOrientation() { }

Powered by Google App Engine
This is Rietveld 408576698