LayoutTests/screen_orientation/resources/sandboxed-iframe-locking.html - Issue 283423005: Use Promises for screen.lockOrientation().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/screen_orientation/resources/sandboxed-iframe-locking.html

Issue 283423005: Use Promises for screen.lockOrientation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: cdumez comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <script>	1 <script>
	jochen (gone - plz use gerrit) 2014/05/22 08:34:35 please add <!DOCTYPE html> please add <!DOCTYPE html> mlamouri (slow - plz ping) 2014/05/22 08:58:56 Done. Show quoted text On 2014/05/22 08:34:35, jochen wrote: > please add <!DOCTYPE html> Done.
2 var exceptionName = "";	2 var msg = "";

3 try {	3 screen.lockOrientation("portrait-primary").then(function() {

4 screen.lockOrientation("portrait-primary");	4 }, function(error) {

5 } catch (ex) {	5 msg = error.name;

6 exceptionName = ex.name;	6 });

7 }	7

8 parent.window.postMessage(exceptionName, "*");	8 // FIXME: for the moment, tests gets notified when there is a failure but

	9 // not a success, this hack should allow us to still have the test running.

	10 // That should be removed as soon as we get a resolved promise in tests.

	11 setTimeout(function() {

	12 parent.window.postMessage(msg, "*");

	13 })

9 </script>	14 </script>

OLD	NEW