Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: base/files/file_path_watcher_mac.cc

Issue 283423003: Use FSEvents for recursive file watch on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/files/file_path_watcher_mac.cc
diff --git a/base/files/file_path_watcher_mac.cc b/base/files/file_path_watcher_mac.cc
new file mode 100644
index 0000000000000000000000000000000000000000..05bf9c2ae3e8a8e1777b5eecc869f96bf20e4909
--- /dev/null
+++ b/base/files/file_path_watcher_mac.cc
@@ -0,0 +1,54 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/files/file_path_watcher.h"
+#include "base/files/file_path_watcher_fsevents.h"
+#include "base/files/file_path_watcher_kqueue.h"
+#include "base/mac/mac_util.h"
+
+namespace base {
+
+namespace {
+
+class FilePathWatcherImpl : public FilePathWatcher::PlatformDelegate {
+ public:
+ virtual bool Watch(const FilePath& path,
+ bool recursive,
+ const FilePathWatcher::Callback& callback) OVERRIDE {
+ DCHECK(!impl_.get());
+ if (recursive) {
+ // FSEvents is broken on 10.6 and earlier. See http://crbug.com/54822#c31
+ if (mac::IsOSSnowLeopard())
+ return false;
+
+ impl_ = new FilePathWatcherFSEvents();
+ } else {
+ impl_ = new FilePathWatcherKQueue();
+ }
+ return impl_->Watch(path, recursive, callback);
+ }
+
+ virtual void Cancel() OVERRIDE {
+ if (impl_)
+ impl_->Cancel();
+ }
+
+ virtual void CancelOnMessageLoopThread() OVERRIDE {
+ if (impl_)
+ impl_->Cancel();
+ }
+
+ protected:
+ virtual ~FilePathWatcherImpl() {}
+
+ scoped_refptr<PlatformDelegate> impl_;
+};
+
+} // namespace
+
+FilePathWatcher::FilePathWatcher() {
+ impl_ = new FilePathWatcherImpl();
+}
+
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698