Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: chrome/browser/google/chrome_google_url_tracker_client.cc

Issue 283413002: Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google/chrome_google_url_tracker_client.cc
diff --git a/chrome/browser/google/chrome_google_url_tracker_client.cc b/chrome/browser/google/chrome_google_url_tracker_client.cc
index 2d8a1e50196c30120182212624ac987866b180d1..541666920ba805f1f0986612ddf63940895ad9d2 100644
--- a/chrome/browser/google/chrome_google_url_tracker_client.cc
+++ b/chrome/browser/google/chrome_google_url_tracker_client.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/google/google_url_tracker.h"
+#include "chrome/browser/google/google_url_tracker_navigation_helper_impl.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_entry.h"
@@ -48,12 +49,13 @@ void ChromeGoogleURLTrackerClient::Observe(
content::Source<content::NavigationController>(source).ptr();
InfoBarService* infobar_service =
InfoBarService::FromWebContents(controller->GetWebContents());
- // Because we're listening to all sources, there may be no
- // InfoBarService for some notifications, e.g. navigations in
- // bubbles/balloons etc.
+ // Because we're listening to all sources, there may be no InfoBarService for
+ // some notifications, e.g. navigations in bubbles/balloons etc.
if (infobar_service) {
google_url_tracker()->OnNavigationPending(
- controller,
+ scoped_ptr<GoogleURLTrackerNavigationHelper>(
+ new GoogleURLTrackerNavigationHelperImpl(
+ controller->GetWebContents(), google_url_tracker())),
infobar_service,
controller->GetPendingEntry()->GetUniqueID());
}
« no previous file with comments | « no previous file | chrome/browser/google/google_url_tracker.h » ('j') | chrome/browser/google/google_url_tracker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698