Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object.

chrome/browser/google/google_url_tracker.h

Index: chrome/browser/google/google_url_tracker.h
diff --git a/chrome/browser/google/google_url_tracker.h b/chrome/browser/google/google_url_tracker.h
index 7499dd4577512b50f3920e4292035e44bd0bea7d..5a0229b6d975546f352c883b5977c6952a0a30ed 100644
--- a/chrome/browser/google/google_url_tracker.h
+++ b/chrome/browser/google/google_url_tracker.h
@@ -25,10 +25,6 @@ class GoogleURLTrackerNavigationHelper;
 class PrefService;
 class Profile;
 
-namespace content {
-class NavigationController;
-}
-
 namespace infobars {
 class InfoBar;
 }
@@ -65,7 +61,6 @@ class GoogleURLTracker : public net::URLFetcherDelegate,
   // GoogleURLTrackerFactory::GetForProfile().
   GoogleURLTracker(Profile* profile,
                    scoped_ptr<GoogleURLTrackerClient> client,
-                   scoped_ptr<GoogleURLTrackerNavigationHelper> nav_helper,
                    Mode mode);
 
   virtual ~GoogleURLTracker();
@@ -106,16 +101,15 @@ class GoogleURLTracker : public net::URLFetcherDelegate,
 
   // Called by the client after SearchCommitted() registers listeners, to
   // indicate that we've received the "load now pending" notification.
-  // |navigation_controller| is the NavigationController for this load;
+  // |nav_helper| is the GoogleURLTrackerNavigationHelper for this load;
   // |infobar_service| is the InfoBarService of the associated tab; and
   // |pending_id| is the unique ID of the newly pending NavigationEntry.  If
   // there is already a visible GoogleURLTracker infobar for this tab, this
   // function resets its associated pending entry ID to the new ID.  Otherwise
   // this function creates a map entry for the associated tab.
-  virtual void OnNavigationPending(
-      content::NavigationController* navigation_controller,
-      InfoBarService* infobar_service,
-      int pending_id);
+  virtual void OnNavigationPending(GoogleURLTrackerNavigationHelper* nav_helper,
+                                   InfoBarService* infobar_service,
+                                   int pending_id);
 
   // Called by the navigation observer once a load we're watching commits.
   // |infobar_service| is the same as for OnNavigationPending();
@@ -124,8 +118,7 @@ class GoogleURLTracker : public net::URLFetcherDelegate,
                                      const GURL& search_url);
 
   // Called by the navigation observer when a tab closes.
-  virtual void OnTabClosed(
-      content::NavigationController* navigation_controller);
+  virtual void OnTabClosed(GoogleURLTrackerNavigationHelper* nav_helper);
 
   static const char kDefaultGoogleHomepage[];
   static const char kSearchDomainCheckURL[];
@@ -174,15 +167,13 @@ class GoogleURLTracker : public net::URLFetcherDelegate,
   // listener if there are no remaining listeners for navigation commits, as we
   // no longer need them until another search is committed.
   void UnregisterForEntrySpecificNotifications(
-      const GoogleURLTrackerMapEntry& map_entry,

[blundell, 2014/05/15 15:24:14]

The reason for the removal of const several places is that
GoogleURLTrackerMapEntry is now storing NavigationHelpers on which non-const
methods are being called, vs. NavigationControllers that were just being used as
pointer values.

[Peter Kasting, 2014/05/15 21:29:52]

OK, but then you need to pass these objects as pointers, not non-const refs.

[blundell, 2014/05/16 11:54:18]

Done.

+      GoogleURLTrackerMapEntry& map_entry,
       bool must_be_listening_for_commit);
 
   Profile* profile_;
 
   scoped_ptr<GoogleURLTrackerClient> client_;
 
-  scoped_ptr<GoogleURLTrackerNavigationHelper> nav_helper_;
-
   // Creates an infobar and adds it to the provided InfoBarService.  Returns the
   // infobar on success or NULL on failure.  The caller does not own the
   // returned object, the InfoBarService does.