Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 2834123002: cc: Replace render surface layer list with a render surface list (Closed)
Patch Set: Address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_impl.h ('k') | cc/trees/layer_tree_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index 0461219ab9aa55850c103b94902fdf4c8b71d02e..8e5a1d4d7844ce6bedcc6d71f04f2e2d0ddb736c 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -379,7 +379,7 @@ gfx::ScrollOffset LayerTreeImpl::TotalMaxScrollOffset() const {
std::unique_ptr<OwnedLayerImplList> LayerTreeImpl::DetachLayers() {
root_layer_for_testing_ = nullptr;
layer_list_.clear();
- render_surface_layer_list_.clear();
+ render_surface_list_.clear();
set_needs_update_draw_properties();
std::unique_ptr<OwnedLayerImplList> ret = std::move(layers_);
layers_.reset(new OwnedLayerImplList);
@@ -1036,7 +1036,7 @@ bool LayerTreeImpl::UpdateDrawProperties(bool update_lcd_text) {
// Clear this after the renderer early out, as it should still be
// possible to hit test even without a renderer.
- render_surface_layer_list_.clear();
+ render_surface_list_.clear();
if (layer_list_.empty())
return false;
@@ -1062,7 +1062,7 @@ bool LayerTreeImpl::UpdateDrawProperties(bool update_lcd_text) {
OverscrollElasticityLayer(), resource_provider()->max_texture_size(),
can_render_to_separate_surface,
settings().layer_transforms_should_scale_layer_contents,
- &render_surface_layer_list_, &property_trees_);
+ &render_surface_list_, &property_trees_);
LayerTreeHostCommon::CalculateDrawProperties(&inputs);
if (const char* client_name = GetClientNameForMetrics()) {
UMA_HISTOGRAM_COUNTS(
@@ -1072,7 +1072,7 @@ bool LayerTreeImpl::UpdateDrawProperties(bool update_lcd_text) {
timer.Elapsed().InMicroseconds());
UMA_HISTOGRAM_COUNTS_100(
base::StringPrintf("Compositing.%s.NumRenderSurfaces", client_name),
- base::saturated_cast<int>(render_surface_layer_list_.size()));
+ base::saturated_cast<int>(render_surface_list_.size()));
}
}
@@ -1200,15 +1200,15 @@ void LayerTreeImpl::BuildPropertyTreesForTesting() {
property_trees_.transform_tree.set_source_to_parent_updates_allowed(false);
}
-const LayerImplList& LayerTreeImpl::RenderSurfaceLayerList() const {
+const RenderSurfaceList& LayerTreeImpl::GetRenderSurfaceList() const {
// If this assert triggers, then the list is dirty.
DCHECK(!needs_update_draw_properties_);
- return render_surface_layer_list_;
+ return render_surface_list_;
}
const Region& LayerTreeImpl::UnoccludedScreenSpaceRegion() const {
- // If this assert triggers, then the render_surface_layer_list_ is dirty, so
- // the unoccluded_screen_space_region_ is not valid anymore.
+ // If this assert triggers, then the render_surface_list_ is dirty, so the
+ // unoccluded_screen_space_region_ is not valid anymore.
DCHECK(!needs_update_draw_properties_);
return unoccluded_screen_space_region_;
}
« no previous file with comments | « cc/trees/layer_tree_impl.h ('k') | cc/trees/layer_tree_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698