Issue 2834059: [Mac] Give active tabs an appropriate inner highlight to reduce visual artifa...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2834059: [Mac] Give active tabs an appropriate inner highlight to reduce visual artifa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Andrew Bonventre (Bons)

Modified:
3 years, 10 months ago

Reviewers:
Mark Mentovai - out til August, pink

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Give active tabs an appropriate inner highlight to reduce visual artifacts caused by the toolbar border/highlight not matching the tab's. Also clean up the tab view class a bit. http://cl.ly/09ac3bec2f1e0eca91db TEST=visual BUG=44574 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53128

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -69 lines)			Patch
	M	chrome/browser/cocoa/tab_view.mm	View	1	9 chunks	+77 lines, -69 lines	0 comments	Download

Trybot results:

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai - out til August

LGTM http://codereview.chromium.org/2834059/diff/1/2 File chrome/browser/cocoa/tab_view.mm (right): http://codereview.chromium.org/2834059/diff/1/2#newcode717 chrome/browser/cocoa/tab_view.mm:717: scoped_nsobject<NSColor> borderColor( These scopers aren’t necessary.

4 years, 10 months ago (2010-07-20 22:43:17 UTC) #1

LGTM, this is f-ing awesome.

Expand Messages | Collapse Messages