Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Issue 2834053004: DevTools: Fix timeline overview flickering (Closed)
Patch Set: addressing comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 17 matching lines...) Expand all
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 UI.Dialog = class extends UI.GlassPane { 31 UI.Dialog = class extends UI.GlassPane {
32 constructor() { 32 constructor() {
33 super(); 33 super();
34 this.registerRequiredCSS('ui/dialog.css'); 34 this.registerRequiredCSS('ui/dialog.css');
35 this.contentElement.tabIndex = 0; 35 this.contentElement.tabIndex = 0;
36 this.contentElement.addEventListener('focus', () => this.widget().focus(), f alse); 36 this.contentElement.addEventListener('focus', () => this.widget().focus(), f alse);
37 this.contentElement.addEventListener('keydown', this._onKeyDown.bind(this), false); 37 this.contentElement.addEventListener('keydown', this._onKeyDown.bind(this), false);
38 this.setBlockPointerEvents(true); 38 this.setPointerEventsBehavior(UI.GlassPane.PointerEventsBehavior.BlockedByGl assPane);
39 this.setSetOutsideClickCallback(event => { 39 this.setSetOutsideClickCallback(event => {
40 this.hide(); 40 this.hide();
41 event.consume(true); 41 event.consume(true);
42 }); 42 });
43 /** @type {!Map<!HTMLElement, number>} */ 43 /** @type {!Map<!HTMLElement, number>} */
44 this._tabIndexMap = new Map(); 44 this._tabIndexMap = new Map();
45 /** @type {?UI.WidgetFocusRestorer} */ 45 /** @type {?UI.WidgetFocusRestorer} */
46 this._focusRestorer = null; 46 this._focusRestorer = null;
47 } 47 }
48 48
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 /** 110 /**
111 * @param {!Event} event 111 * @param {!Event} event
112 */ 112 */
113 _onKeyDown(event) { 113 _onKeyDown(event) {
114 if (event.keyCode === UI.KeyboardShortcut.Keys.Esc.code) { 114 if (event.keyCode === UI.KeyboardShortcut.Keys.Esc.code) {
115 event.consume(true); 115 event.consume(true);
116 this.hide(); 116 this.hide();
117 } 117 }
118 } 118 }
119 }; 119 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698