third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.cpp - Issue 2834053003: Split V8Binding

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.cpp

Issue 2834053003: Split V8Binding (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilderTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "bindings/core/v8/V8ObjectBuilder.h"	5 #include "bindings/core/v8/V8ObjectBuilder.h"

6	6

7 #include "bindings/core/v8/V8Binding.h"	7 #include "bindings/core/v8/V8BindingForCore.h"

8	8

9 namespace blink {	9 namespace blink {

10	10

11 V8ObjectBuilder::V8ObjectBuilder(ScriptState* script_state)	11 V8ObjectBuilder::V8ObjectBuilder(ScriptState* script_state)

12 : script_state_(script_state),	12 : script_state_(script_state),

13 object_(v8::Object::New(script_state->GetIsolate())) {}	13 object_(v8::Object::New(script_state->GetIsolate())) {}

14	14

15 V8ObjectBuilder& V8ObjectBuilder::Add(const StringView& name,	15 V8ObjectBuilder& V8ObjectBuilder::Add(const StringView& name,

16 const V8ObjectBuilder& value) {	16 const V8ObjectBuilder& value) {

17 AddInternal(name, value.V8Value());	17 AddInternal(name, value.V8Value());

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 if (value.IsEmpty() \|\|	63 if (value.IsEmpty() \|\|

64 object_	64 object_

65 ->CreateDataProperty(script_state_->GetContext(),	65 ->CreateDataProperty(script_state_->GetContext(),

66 V8String(script_state_->GetIsolate(), name),	66 V8String(script_state_->GetIsolate(), name),

67 value)	67 value)

68 .IsNothing())	68 .IsNothing())

69 object_.Clear();	69 object_.Clear();

70 }	70 }

71	71

72 } // namespace blink	72 } // namespace blink

OLD	NEW