Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: content/common/navigation_params.cc

Issue 2834013002: PlzNavigate: make MHTML iframe load working. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/navigation_params.cc
diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc
index e2148964f89b3e177019e997c16d72147d7d2a82..5881d583f8440689c9c67b751fae0b3cfc4ccc58 100644
--- a/content/common/navigation_params.cc
+++ b/content/common/navigation_params.cc
@@ -32,6 +32,15 @@ bool ShouldMakeNetworkRequestForURL(const GURL& url) {
return false;
}
+ // For you information, even though a "data:" url doesn't generate actual
+ // network requests, it is handled by the network stack and so must return
+ // true. The reason is that a few "data:" urls can't be handled locally. For
+ // instance:
+ // - the ones that result in downloads.
+ // - the ones that are invalid. An error page must be served instead.
+ // - the ones that have an unsupported MIME type.
+ // - the ones that target the top-level frame on Android.
+
return true;
}
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698