Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2290)

Unified Diff: content/common/navigation_params_unittest.cc

Issue 2834013002: PlzNavigate: make MHTML iframe load working. (Closed)
Patch Set: Addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/navigation_params_unittest.cc
diff --git a/content/common/navigation_params_unittest.cc b/content/common/navigation_params_unittest.cc
index ee1f96a68e0f890529f18b60a8a4e1254bffa109..e78e59753842193fc9e69531b74759b03ad99b2b 100644
--- a/content/common/navigation_params_unittest.cc
+++ b/content/common/navigation_params_unittest.cc
@@ -16,6 +16,8 @@ TEST(NavigationParamsTest, ShouldMakeNetworkRequestForURL) {
EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("http://foo/bar.html")));
EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("https://foo/bar.html")));
+ // Even though a "data" url doesn't generate actual network requests. It is
nasko 2017/05/04 15:48:18 nit: "data:", since it is a scheme. "requests, it
arthursonzogni 2017/05/05 09:07:46 I will list some reasons why some data-urls requir
+ // handled by the network stack and so must return true for this check.
EXPECT_TRUE(ShouldMakeNetworkRequestForURL(GURL("data://foo")));
EXPECT_FALSE(ShouldMakeNetworkRequestForURL(GURL("about:blank")));
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698