PlzNavigate: make MHTML iframe load working.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 5580 matching lines @@
     }
 
     // |navigation_start| must be recorded immediately after dispatching the
     // beforeunload event.
     if (pending_navigation_params_) {
       pending_navigation_params_->common_params.navigation_start =
           base::TimeTicks::Now();
     }
   }
 
+  // When an MHTML Archive is present, it should be used to serve iframe content
+  // instead of doing a network request.
+  bool use_archive =
+      (info.archive_status == NavigationPolicyInfo::ArchiveStatus::Present) &&
+      !url.SchemeIs(url::kDataScheme);
+
   // PlzNavigate: if the navigation is not synchronous, send it to the browser.
   // This includes navigations with no request being sent to the network stack.
   if (IsBrowserSideNavigationEnabled() &&
       info.url_request.CheckForBrowserSideNavigation() &&
-      ShouldMakeNetworkRequestForURL(url)) {
+      ShouldMakeNetworkRequestForURL(url) && !use_archive) {

[nasko, 2017/05/03 17:28:39]

I'm not sure I follow why we should be sending "cid:Something" requests to the
network stack. Since we don't expect them outside of MHTML, shouldn't we have a
simple check that says "if !archive && cid, return ignore" (or if there is a
better policy value)?

[arthursonzogni, 2017/05/04 14:26:32]

See my first answer above.

     if (info.default_policy == blink::kWebNavigationPolicyCurrentTab) {
       // The BeginNavigation() call happens in didStartProvisionalLoad(). We
       // need to save information about the navigation here.
       pending_navigation_info_.reset(new PendingNavigationInfo(info));
       return blink::kWebNavigationPolicyHandledByClient;
     } else {
       LoadURLExternally(info.url_request, info.default_policy);
       return blink::kWebNavigationPolicyIgnore;
     }
   }
@@ skipping 1424 matching lines @@
       policy(info.default_policy),
       replaces_current_history_item(info.replaces_current_history_item),
       history_navigation_in_new_child_frame(
           info.is_history_navigation_in_new_child_frame),
       client_redirect(info.is_client_redirect),
       cache_disabled(info.is_cache_disabled),
       form(info.form),
       source_location(info.source_location) {}
 
 }  // namespace content