Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5491)

Unified Diff: chrome/browser/resources/print_preview/native_layer.js

Issue 2833993004: Print Preview: Make generate draft mode work again. (Closed)
Patch Set: Check NativeLayerStub Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/native_layer.js
diff --git a/chrome/browser/resources/print_preview/native_layer.js b/chrome/browser/resources/print_preview/native_layer.js
index 19c5a53215ff374c1db1f8a0955cf02362a43623..ce994f026f48feb6fe2b4ca368de59141c0a39db 100644
--- a/chrome/browser/resources/print_preview/native_layer.js
+++ b/chrome/browser/resources/print_preview/native_layer.js
@@ -277,10 +277,11 @@ cr.define('print_preview', function() {
* @param {!print_preview.PrintTicketStore} printTicketStore Used to get the
* state of the print ticket.
* @param {!print_preview.DocumentInfo} documentInfo Document data model.
+ * @param {boolean} generateDraft Tell the renderer to re-render.
* @param {number} requestId ID of the preview request.
*/
startGetPreview: function(
- destination, printTicketStore, documentInfo, requestId) {
+ destination, printTicketStore, documentInfo, generateDraft, requestId) {
assert(printTicketStore.isTicketValidForPreview(),
'Trying to generate preview when ticket is not valid');
@@ -294,7 +295,7 @@ cr.define('print_preview', function() {
'isFirstRequest': requestId == 0,
'requestID': requestId,
'previewModifiable': documentInfo.isModifiable,
- 'generateDraftData': documentInfo.isModifiable,
+ 'generateDraftData': generateDraft,
'fitToPageEnabled': printTicketStore.fitToPage.getValue(),
'scaleFactor': printTicketStore.scaling.getValueAsNumber(),
// NOTE: Even though the following fields don't directly relate to the
@@ -341,8 +342,7 @@ cr.define('print_preview', function() {
chrome.send(
'getPreview',
[JSON.stringify(ticket),
- requestId > 0 ? documentInfo.pageCount : -1,
- documentInfo.isModifiable]);
+ requestId > 0 ? documentInfo.pageCount : -1]);
},
/**
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/preview_generator.js » ('j') | chrome/test/data/webui/print_preview.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698