android_webview/native/aw_contents.h - Issue 2833923002: WebView: carefully check size for SafeBrowsing interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.h

Issue 2833923002: WebView: carefully check size for SafeBrowsing interstitial (Closed)

Patch Set: Also check if attached, add @VisibleForTesting Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_contents.h

diff --git a/android_webview/native/aw_contents.h b/android_webview/native/aw_contents.h

index 0fa1fcc9cde4e66fe128648849cc92e8dd80a891..1248bd1791a726df1c8750deffc6566b9f91c88d 100644

--- a/android_webview/native/aw_contents.h

+++ b/android_webview/native/aw_contents.h

@@ -364,7 +364,7 @@ class AwContents : public FindHelper::Listener,

void RenderProcessReady(content::RenderProcessHost* host) override;

// AwSafeBrowsingUIManager::UIManagerClient implementation

- bool CanShowInterstitial() override;

+ bool CanShowBigInterstitial() override;

void CallProceedOnInterstitialForTesting(

JNIEnv* env,