Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: android_webview/browser/aw_browser_terminator.cc

Issue 2833893002: [Android WebView] Trigger minidump uploading on renderer crash. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_browser_terminator.cc
diff --git a/android_webview/browser/aw_browser_terminator.cc b/android_webview/browser/aw_browser_terminator.cc
index 0088138c6d6003790afed9bea599f066b4e20ff0..23d35003c7e5158d67a5e9a0ad07ad79df413e7b 100644
--- a/android_webview/browser/aw_browser_terminator.cc
+++ b/android_webview/browser/aw_browser_terminator.cc
@@ -6,6 +6,7 @@
#include <unistd.h>
+#include "android_webview/browser/aw_browser_process.h"
#include "android_webview/browser/aw_render_process_gone_delegate.h"
#include "android_webview/common/aw_descriptors.h"
#include "android_webview/common/crash_reporter/aw_microdump_crash_reporter.h"
@@ -85,6 +86,13 @@ void OnRenderProcessGoneDetail(int child_process_id,
}
}
}
+
+ // By this point we have moved the minidump to the crash directory, so it can
+ // now be copied and uploaded. This is guaranteed by the order in which we
+ // register breakpad::CrashDumpManager and AwBrowserTerminator as
+ // breakpad::CrashDumpObserver clients over in AwBrowserMainParts
+ // (CrashDumpManager is registered first).
+ TriggerMinidumpUploading();
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698