android_webview/native/aw_browser_process_impl.cc - Issue 2833893002: [Android WebView] Trigger minidump uploading on renderer crash.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/native/aw_browser_process_impl.cc

Issue 2833893002: [Android WebView] Trigger minidump uploading on renderer crash. (Closed)

Patch Set: Post copying-tasks to SERIAL_EXECUTOR instead of THREAD_POOL_EXECUTOR + add several comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "android_webview/browser/aw_browser_process.h"

	6 #include "jni/AwBrowserProcess_jni.h"

	7

	8 namespace android_webview {

	9

	10 void TriggerMinidumpUploading() {
	Tobias Sargeant 2017/04/26 13:29:00 Given that there's no abstract class and its imple Given that there's no abstract class and its implementation here, why is this split up into an _impl file? gsennton 2017/04/26 14:21:04 Good point ;), rename, and removed the empty brows Show quoted text On 2017/04/26 13:29:00, Tobias Sargeant wrote: > Given that there's no abstract class and its implementation here, why is this > split up into an _impl file? Good point ;), rename, and removed the empty browser/ implementation.
	11 JNIEnv* env = base::android::AttachCurrentThread();

	12 Java_AwBrowserProcess_triggerMinidumpUploading(env);

	13 }

	14

	15 } // namespace android_webview

OLD	NEW

« no previous file with comments | « android_webview/native/BUILD.gn ('k') | no next file » | no next file with comments »