Skip paint chunks with effectively invisible opacity.

third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintLayerPainter.h"
 
 #include "core/layout/LayoutBoxModelObject.h"
 #include "core/layout/compositing/CompositedLayerMapping.h"
 #include "core/paint/PaintControllerPaintTest.h"
 #include "platform/graphics/GraphicsContext.h"
@@ skipping 14 matching lines @@
     : public testing::WithParamInterface<PaintLayerPainterTestParam>,
       private ScopedRootLayerScrollingForTest,
       public PaintControllerPaintTestBase {
   USING_FAST_MALLOC(PaintLayerPainterTest);
 
  public:
   PaintLayerPainterTest()
       : ScopedRootLayerScrollingForTest(GetParam().root_layer_scrolling),
         PaintControllerPaintTestBase(GetParam().slimming_paint_v2) {}
 
-  void ExpectPaintedOutputVisibility(const char* element_name,
-                                     bool expected_spv1) {
-    ExpectPaintedOutputVisibility(element_name, expected_spv1, expected_spv1);

[wkorman, 2017/04/20 22:23:56]

With this patch we've seemingly achieved conformity between SPv1 and SPv2.

I expected this to break some passing SPv2 animation tests but running locally I
see only a small number of flaky failures/crashes which I believe is also the
case at ToT.

Am supportive of trying to land this and see how things go.

-  }
-
-  void ExpectPaintedOutputVisibility(const char* element_name,

[wkorman, 2017/04/20 22:23:56]

I renamed this for easier mental parsing w.r.t. its functionality.

-                                     bool expected_spv1,
-                                     bool expected_spv2) {
+  void ExpectPaintedOutputInvisible(const char* element_name,
+                                    bool expected_value) {
     PaintLayer* target_layer =
         ToLayoutBox(GetLayoutObjectByElementId(element_name))->Layer();
     PaintLayerPaintingInfo painting_info(nullptr, LayoutRect(),
                                          kGlobalPaintNormalPhase, LayoutSize());
     bool invisible =
         PaintLayerPainter(*target_layer).PaintedOutputInvisible(painting_info);
-    bool expected_value = RuntimeEnabledFeatures::slimmingPaintV2Enabled()
-                              ? expected_spv2
-                              : expected_spv1;
     EXPECT_EQ(expected_value, invisible)
         << "Failed painted output visibility [spv2_enabled="
         << RuntimeEnabledFeatures::slimmingPaintV2Enabled()
         << ", expected=" << expected_value << ", actual=" << invisible << "].";
   }
 
  private:
   void SetUp() override {
     PaintControllerPaintTestBase::SetUp();
     EnableCompositing();
@@ skipping 726 matching lines @@
   ToHTMLElement(table.GetNode())
       ->setAttribute(HTMLNames::styleAttr,
                      "position: relative; border-collapse: collapse");
   GetDocument().View()->UpdateAllLifecyclePhases();
   EXPECT_TRUE(layer.NeedsPaintPhaseDescendantBlockBackgrounds());
 }
 
 TEST_P(PaintLayerPainterTest, DontPaintWithTinyOpacity) {
   SetBodyInnerHTML(
       "<div id='target' style='background: blue; opacity: 0.0001'></div>");
-  ExpectPaintedOutputVisibility("target", true, false);

[wkorman, 2017/04/20 22:23:56]

Highlighting -- this is one of two test cases standardized by this patch.

+  ExpectPaintedOutputInvisible("target", true);
 }
 
 TEST_P(PaintLayerPainterTest, DoPaintWithTinyOpacityAndWillChangeOpacity) {
   SetBodyInnerHTML(
       "<div id='target' style='background: blue; opacity: 0.0001; "
       "will-change: opacity'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest, DoPaintWithTinyOpacityAndBackdropFilter) {
   SetBodyInnerHTML(
       "<div id='target' style='background: blue; opacity: 0.0001;"
       "  backdrop-filter: blur(2px);'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest,
        DoPaintWithTinyOpacityAndBackdropFilterAndWillChangeOpacity) {
   SetBodyInnerHTML(
       "<div id='target' style='background: blue; opacity: 0.0001;"
       "  backdrop-filter: blur(2px); will-change: opacity'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest, DoPaintWithCompositedTinyOpacity) {
   SetBodyInnerHTML(
       "<div id='target' style='background: blue; opacity: 0.0001;"
       " will-change: transform'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest, DoPaintWithNonTinyOpacity) {
   SetBodyInnerHTML(
       "<div id='target' style='background: blue; opacity: 0.1'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest, DoPaintWithEffectAnimationZeroOpacity) {
   SetBodyInnerHTML(
       "<style> "
       "div { "
       "  width: 100px; "
       "  height: 100px; "
       "  animation-name: example; "
       "  animation-duration: 4s; "
       "} "
       "@keyframes example { "
       "  from { opacity: 0.0;} "
       "  to { opacity: 1.0;} "
       "} "
       "</style> "
       "<div id='target'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest, DontPaintWithTransformAnimationZeroOpacity) {
   SetBodyInnerHTML(
       "<style> "
       "div#target { "
       "  animation-name: example; "
       "  animation-duration: 4s; "
       "  opacity: 0.0; "
       "} "
       "@keyframes example { "
       " from { transform: translate(0px, 0px); } "
       " to { transform: translate(3em, 0px); } "
       "} "
       "</style> "
       "<div id='target'>x</div></div>");
-  ExpectPaintedOutputVisibility("target", false, true);
+  ExpectPaintedOutputInvisible("target", false);

[wkorman, 2017/04/20 22:23:56]

Highlighting -- this is one of two test cases standardized by this patch.

 }
 
 TEST_P(PaintLayerPainterTest,
        DoPaintWithTransformAnimationZeroOpacityWillChangeOpacity) {
   SetBodyInnerHTML(
       "<style> "
       "div#target { "
       "  animation-name: example; "
       "  animation-duration: 4s; "
       "  opacity: 0.0; "
       "  will-change: opacity; "
       "} "
       "@keyframes example { "
       " from { transform: translate(0px, 0px); } "
       " to { transform: translate(3em, 0px); } "
       "} "
       "</style> "
       "<div id='target'>x</div></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest, DoPaintWithWillChangeOpacity) {
   SetBodyInnerHTML(
       "<style> "
       "div { "
       "  width: 100px; "
       "  height: 100px; "
       "  will-change: opacity;"
       "}"
       "</style> "
       "<div id='target'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest, DoPaintWithZeroOpacityAndWillChangeOpacity) {
   SetBodyInnerHTML(
       "<style> "
       "div { "
       "  width: 100px; "
       "  height: 100px; "
       "  opacity: 0; "
       "  will-change: opacity;"
       "}"
       "</style> "
       "<div id='target'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 TEST_P(PaintLayerPainterTest,
        DoPaintWithNoContentAndZeroOpacityAndWillChangeOpacity) {
   SetBodyInnerHTML(
       "<style> "
       "div { "
       "  width: 100px; "
       "  height: 100px; "
       "  opacity: 0; "
       "  will-change: opacity;"
       "}"
       "</style> "
       "<div id='target'></div>");
-  ExpectPaintedOutputVisibility("target", false);
+  ExpectPaintedOutputInvisible("target", false);
 }
 
 }  // namespace blink