content/renderer/accessibility/blink_ax_tree_source.cc - Issue 2833843005: Handling of different types of empty alt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2833843005: Handling of different types of empty alt (Closed)

Patch Set: Temporary test fix until we figure out why returning null for name does not work Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 397c86e42ad0ce14085125a9a9e722163783a016..10a824c44e57b1a4c746edb21d7857ca11ef8080 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -405,7 +405,8 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

blink::WebAXNameFrom nameFrom;

blink::WebVector<blink::WebAXObject> nameObjects;

blink::WebString web_name = src.GetName(nameFrom, nameObjects);

- if (!web_name.IsEmpty()) {

+ if ((!web_name.IsEmpty() && !web_name.IsNull()) ||

+ nameFrom == blink::kWebAXNameFromExplicitlyEmptyAttribute) {

dst->AddStringAttribute(ui::AX_ATTR_NAME, web_name.Utf8());

dst->AddIntAttribute(ui::AX_ATTR_NAME_FROM, AXNameFromFromBlink(nameFrom));

AddIntListAttributeFromWebObjects(