Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: content/browser/accessibility/browser_accessibility_auralinux.cc

Issue 2833843005: Handling of different types of empty alt (Closed)
Patch Set: Temporary test fix until we figure out why returning null for name does not work Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_auralinux.cc
diff --git a/content/browser/accessibility/browser_accessibility_auralinux.cc b/content/browser/accessibility/browser_accessibility_auralinux.cc
index 6e2064e98225fafbad989d843e06750786f8fcad..7e3e9004a133c62889dc0aec7421d992ae769d78 100644
--- a/content/browser/accessibility/browser_accessibility_auralinux.cc
+++ b/content/browser/accessibility/browser_accessibility_auralinux.cc
@@ -471,7 +471,12 @@ static const gchar* browser_accessibility_get_name(AtkObject* atk_object) {
if (!obj)
return NULL;
- return obj->GetStringAttribute(ui::AX_ATTR_NAME).c_str();
+ const std::string name = obj->GetStringAttribute(ui::AX_ATTR_NAME);
+ // TODO(aleventhal) Why does this crash tests on trybot, but not locally?
+ // if (name.empty() && !obj->HasExplicitlyEmptyName())
+ // return NULL;
+
+ return name.c_str();
}
static const gchar* browser_accessibility_get_description(

Powered by Google App Engine
This is Rietveld 408576698