content/browser/accessibility/browser_accessibility.cc - Issue 2833843005: Handling of different types of empty alt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 2833843005: Handling of different types of empty alt (Closed)

Patch Set: Temporary test fix until we figure out why returning null for name does not work Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility.cc

diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc

index 95647cb7b211f539967c7e0611bba5342ecc1398..b8f221e31f5f17ee083d41f668d2e44de023746f 100644

--- a/content/browser/accessibility/browser_accessibility.cc

+++ b/content/browser/accessibility/browser_accessibility.cc

@@ -1023,6 +1023,11 @@ bool BrowserAccessibility::IsRichTextControl() const {

!PlatformGetParent()->HasState(ui::AX_STATE_RICHLY_EDITABLE));

}

+bool BrowserAccessibility::HasExplicitlyEmptyName() const {

+ return GetIntAttribute(ui::AX_ATTR_NAME_FROM) ==

+ ui::AX_NAME_FROM_EXPLICITLY_EMPTY_ATTRIBUTE;

std::string BrowserAccessibility::ComputeAccessibleNameFromDescendants() {

std::string name;

for (size_t i = 0; i < InternalChildCount(); ++i) {