Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_win.cc

Issue 2833843005: Handling of different types of empty alt (Closed)
Patch Set: Temporary test fix until we figure out why returning null for name does not work Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/accessibility_tree_formatter_win.cc
diff --git a/content/browser/accessibility/accessibility_tree_formatter_win.cc b/content/browser/accessibility/accessibility_tree_formatter_win.cc
index b454ae26b1bd4fd949797f8f5c0111aa01189943..44068832d789558a1cf72e5d70ac2560fdb4e602 100644
--- a/content/browser/accessibility/accessibility_tree_formatter_win.cc
+++ b/content/browser/accessibility/accessibility_tree_formatter_win.cc
@@ -171,7 +171,8 @@ void AccessibilityTreeFormatterWin::AddProperties(
dict->SetString("role", IAccessible2RoleToString(ax_object->ia2_role()));
base::win::ScopedBstr temp_bstr;
- if (SUCCEEDED(ax_object->get_accName(variant_self, temp_bstr.Receive()))) {
+ // If S_FALSE it means there is no name
+ if (S_OK == ax_object->get_accName(variant_self, temp_bstr.Receive())) {
base::string16 name = base::string16(temp_bstr, temp_bstr.Length());
// Ignore a JAWS workaround where the name of a document is " ".
@@ -366,11 +367,12 @@ base::string16 AccessibilityTreeFormatterWin::ToString(
case base::Value::Type::STRING: {
base::string16 string_value;
value->GetAsString(&string_value);
- WriteAttribute(false,
- base::StringPrintf(L"%ls='%ls'",
- base::UTF8ToUTF16(attribute_name).c_str(),
- string_value.c_str()),
- &line);
+ WriteAttribute(
+ false,
+ base::StringPrintf(L"%ls='%ls'",
+ base::UTF8ToUTF16(attribute_name).c_str(),
+ string_value.c_str()),
+ &line);
break;
}
case base::Value::Type::INTEGER: {

Powered by Google App Engine
This is Rietveld 408576698