Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: test/cctest/test-mementos.cc

Issue 283383006: Inobject slack tracking is done on a per-closure basis instead of per-shared info basis. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Bugfixes, improvements, cleanup Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.h ('K') | « src/x64/builtins-x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-mementos.cc
diff --git a/test/cctest/test-mementos.cc b/test/cctest/test-mementos.cc
index a377b4a4c6f31c0a8139f3dc9d1ae95ee37de817..5ed755ffd4665f6d128e90b4ce57bb41d2c89df5 100644
--- a/test/cctest/test-mementos.cc
+++ b/test/cctest/test-mementos.cc
@@ -91,8 +91,7 @@ TEST(PretenuringCallNew) {
// We need to create several instances to get past the slack-tracking
// phase, where mementos aren't emitted.
- int call_count = 10;
- CHECK_GE(call_count, SharedFunctionInfo::kGenerousAllocationCount);
+ unsigned int call_count = JSFunction::kGenerousAllocationCount + 2;
Michael Starzinger 2014/05/21 10:42:01 nit: Likewise, plain "int" should do it here.
Igor Sheludko 2014/05/22 08:05:42 Done. Actually now there should be exactly call_co
i::ScopedVector<char> test_buf(1024);
const char* program =
"function f() {"
@@ -119,6 +118,6 @@ TEST(PretenuringCallNew) {
// Furthermore, how many mementos did we create? The count should match
// call_count - SharedFunctionInfo::kGenerousAllocationCount.
AllocationSite* site = memento->GetAllocationSite();
- CHECK_EQ(call_count - SharedFunctionInfo::kGenerousAllocationCount,
+ CHECK_EQ(call_count - JSFunction::kGenerousAllocationCount,
site->pretenure_create_count()->value());
}
« src/objects.h ('K') | « src/x64/builtins-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698