src/hydrogen.cc - Issue 283383006: Inobject slack tracking is done on a per-closure basis instead of per-shared info basis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 283383006: Inobject slack tracking is done on a per-closure basis instead of per-shared info basis. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 46f893d26afa6e6ad2a883cae59ce1209a07fa75..58b4b8333aac0d6c3420a50c736e397f5e652ce6 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -8546,8 +8546,8 @@ void HOptimizedGraphBuilder::VisitCallNew(CallNew* expr) {

// Force completion of inobject slack tracking before generating

// allocation code to finalize instance size.

- if (constructor->shared()->IsInobjectSlackTrackingInProgress()) {

- constructor->shared()->CompleteInobjectSlackTracking();

+ if (constructor->IsInobjectSlackTrackingInProgress()) {

+ constructor->CompleteInobjectSlackTracking();

}

// Calculate instance size from initial map of constructor.

« no previous file with comments | « src/heap-snapshot-generator.cc ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »