src/heap.cc - Issue 283383006: Inobject slack tracking is done on a per-closure basis instead of per-shared info basis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 283383006: Inobject slack tracking is done on a per-closure basis instead of per-shared info basis. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index f0c9154b5e9aa15cb45f00df5b5e43533b966979..d628fbd75adc8a20f82471f1e45456f3c504e4f8 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -3621,7 +3621,7 @@ void Heap::InitializeJSObjectFromMap(JSObject* obj,

// so that object accesses before the constructor completes (e.g. in the

// debugger) will not cause a crash.

if (map->constructor()->IsJSFunction() &&

- JSFunction::cast(map->constructor())->shared()->

+ JSFunction::cast(map->constructor())->

IsInobjectSlackTrackingInProgress()) {

// We might want to shrink the object later.

ASSERT(obj->GetInternalFieldCount() == 0);

« no previous file with comments | « src/factory.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »