Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: test/cctest/test-mementos.cc

Issue 283383006: Inobject slack tracking is done on a per-closure basis instead of per-shared info basis. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Bugfixes, improvements, cleanup Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/objects.h ('K') | « src/x64/builtins-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 CcTest::InitializeVM(); 84 CcTest::InitializeVM();
85 if (!i::FLAG_allocation_site_pretenuring) return; 85 if (!i::FLAG_allocation_site_pretenuring) return;
86 if (!i::FLAG_pretenuring_call_new) return; 86 if (!i::FLAG_pretenuring_call_new) return;
87 87
88 v8::HandleScope scope(CcTest::isolate()); 88 v8::HandleScope scope(CcTest::isolate());
89 Isolate* isolate = CcTest::i_isolate(); 89 Isolate* isolate = CcTest::i_isolate();
90 Heap* heap = isolate->heap(); 90 Heap* heap = isolate->heap();
91 91
92 // We need to create several instances to get past the slack-tracking 92 // We need to create several instances to get past the slack-tracking
93 // phase, where mementos aren't emitted. 93 // phase, where mementos aren't emitted.
94 int call_count = 10; 94 unsigned int call_count = JSFunction::kGenerousAllocationCount + 2;
Michael Starzinger 2014/05/21 10:42:01 nit: Likewise, plain "int" should do it here.
Igor Sheludko 2014/05/22 08:05:42 Done. Actually now there should be exactly call_co
95 CHECK_GE(call_count, SharedFunctionInfo::kGenerousAllocationCount);
96 i::ScopedVector<char> test_buf(1024); 95 i::ScopedVector<char> test_buf(1024);
97 const char* program = 96 const char* program =
98 "function f() {" 97 "function f() {"
99 " this.a = 3;" 98 " this.a = 3;"
100 " this.b = {};" 99 " this.b = {};"
101 " return this;" 100 " return this;"
102 "};" 101 "};"
103 "var a;" 102 "var a;"
104 "for(var i = 0; i < %d; i++) {" 103 "for(var i = 0; i < %d; i++) {"
105 " a = new f();" 104 " a = new f();"
106 "}" 105 "}"
107 "a;"; 106 "a;";
108 i::OS::SNPrintF(test_buf, program, call_count); 107 i::OS::SNPrintF(test_buf, program, call_count);
109 v8::Local<v8::Value> res = CompileRun(test_buf.start()); 108 v8::Local<v8::Value> res = CompileRun(test_buf.start());
110 Handle<JSObject> o = 109 Handle<JSObject> o =
111 v8::Utils::OpenHandle(*v8::Handle<v8::Object>::Cast(res)); 110 v8::Utils::OpenHandle(*v8::Handle<v8::Object>::Cast(res));
112 111
113 // The object of class f should have a memento secreted behind it. 112 // The object of class f should have a memento secreted behind it.
114 Address memento_address = o->address() + o->map()->instance_size(); 113 Address memento_address = o->address() + o->map()->instance_size();
115 AllocationMemento* memento = 114 AllocationMemento* memento =
116 reinterpret_cast<AllocationMemento*>(memento_address + kHeapObjectTag); 115 reinterpret_cast<AllocationMemento*>(memento_address + kHeapObjectTag);
117 CHECK_EQ(memento->map(), heap->allocation_memento_map()); 116 CHECK_EQ(memento->map(), heap->allocation_memento_map());
118 117
119 // Furthermore, how many mementos did we create? The count should match 118 // Furthermore, how many mementos did we create? The count should match
120 // call_count - SharedFunctionInfo::kGenerousAllocationCount. 119 // call_count - SharedFunctionInfo::kGenerousAllocationCount.
121 AllocationSite* site = memento->GetAllocationSite(); 120 AllocationSite* site = memento->GetAllocationSite();
122 CHECK_EQ(call_count - SharedFunctionInfo::kGenerousAllocationCount, 121 CHECK_EQ(call_count - JSFunction::kGenerousAllocationCount,
123 site->pretenure_create_count()->value()); 122 site->pretenure_create_count()->value());
124 } 123 }
OLDNEW
« src/objects.h ('K') | « src/x64/builtins-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698