Pause drawing webvr when the App button is pressed

chrome/browser/android/vr_shell/vr_shell.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/vr_shell.h"
 
 #include <android/native_window_jni.h>
 
 #include <string>
 #include <utility>
@@ skipping 190 matching lines @@
   g_instance = nullptr;
 }
 
 void VrShell::PostToGlThreadWhenReady(const base::Closure& task) {
   // TODO(mthiesse): Remove this blocking wait. Queue up events if thread isn't
   // finished starting?
   gl_thread_->WaitUntilThreadStarted();
   gl_thread_->task_runner()->PostTask(FROM_HERE, task);
 }
 
-void VrShell::SetContentPaused(bool paused) {
-  if (content_paused_ == paused)
-    return;
-  content_paused_ = paused;
-
+void VrShell::OnContentPaused(bool paused) {
   if (!delegate_provider_->device_provider())
     return;
 
   // TODO(mthiesse): The page is no longer visible when in menu mode. We
   // should unfocus or otherwise let it know it's hidden.
-  if (paused) {
+  if (paused)
     delegate_provider_->device_provider()->Device()->OnBlur();
-  } else {
+  else
     delegate_provider_->device_provider()->Device()->OnFocus();
-  }
 }
 
 void VrShell::OnTriggerEvent(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   gl_thread_->task_runner()->PostTask(
       FROM_HERE,
       base::Bind(&VrShellGl::OnTriggerEvent, gl_thread_->GetVrShellGl()));
 }
 
 void VrShell::OnPause(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   gl_thread_->task_runner()->PostTask(
@@ skipping 159 matching lines @@
 
 void VrShell::GvrDelegateReady() {
   delegate_provider_->SetPresentingDelegate(this, gvr_api_);
 }
 
 void VrShell::AppButtonGesturePerformed(UiInterface::Direction direction) {
   if (vr_shell_enabled_)
     ui_->HandleAppButtonGesturePerformed(direction);
 }
 
-void VrShell::AppButtonPressed() {
-  if (vr_shell_enabled_)
+void VrShell::AppButtonPressed(bool content_paused) {
+  if (vr_shell_enabled_) {
+    OnContentPaused(content_paused);
     ui_->HandleAppButtonClicked();
+  }
 }
 
 void VrShell::ContentPhysicalBoundsChanged(JNIEnv* env,
                                            const JavaParamRef<jobject>& object,
                                            jint width,
                                            jint height,
                                            jfloat dpr) {
   TRACE_EVENT0("gpu", "VrShell::ContentPhysicalBoundsChanged");
   PostToGlThreadWhenReady(base::Bind(&VrShellGl::ContentPhysicalBoundsChanged,
                                      gl_thread_->GetVrShellGl(), width,
                                      height));
   compositor_->SetWindowBounds(gfx::Size(width, height));
 }
 
 void VrShell::DoUiAction(const UiAction action,
                          const base::DictionaryValue* arguments) {
   // Actions that can be handled natively.
   switch (action) {
     case SET_CONTENT_PAUSED: {

[bshe, 2017/04/21 21:08:42]

wondering if this UiAction is still needed? If not, perhap remove it?

[ymalik, 2017/04/28 00:12:04]

I think we have it here as reference for things that need to be implemented.
Added comment to clarify.

-      bool paused;
-      CHECK(arguments->GetBoolean("paused", &paused));
-      SetContentPaused(paused);
       return;
     }
     case HISTORY_BACK:
       if (web_contents_ && web_contents_->IsFullscreen()) {
         web_contents_->ExitFullscreen(false);
         return;
       }
       // Otherwise handle in java.
       break;
     case EXIT_PRESENT:
@@ skipping 123 matching lines @@
            jboolean for_web_vr,
            jlong gvr_api,
            jboolean reprojected_rendering) {
   return reinterpret_cast<intptr_t>(new VrShell(
       env, obj, reinterpret_cast<ui::WindowAndroid*>(window_android),
       for_web_vr, VrShellDelegate::GetNativeVrShellDelegate(env, delegate),
       reinterpret_cast<gvr_context*>(gvr_api), reprojected_rendering));
 }
 
 }  // namespace vr_shell