Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2833733003: Remove state for expression evaluation (Closed)

Created:
3 years, 8 months ago by zhivkag
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rename variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -161 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 13 chunks +171 lines, -161 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zhivkag
Hi, This change removes the ExpressionState for evaluation of expressions in the Evaluator. As discussed ...
3 years, 8 months ago (2017-04-21 07:55:45 UTC) #2
Kevin Millikin (Google)
I like it. LGTM.
3 years, 8 months ago (2017-04-21 08:06:21 UTC) #3
Dmitry Stefantsov
LGTM as well.
3 years, 8 months ago (2017-04-21 08:10:03 UTC) #4
zhivkag
3 years, 8 months ago (2017-04-21 08:11:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4f59c41c5f9e24494d7dbd1504273ff5de099af0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698