Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 283373003: Use %DebugGetProperty in debug mirror to check for Promise. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use %DebugGetProperty in debug mirror to check for Promise. R=aandrey@chromium.org, amikhaylova@google.com Committed: https://code.google.com/p/v8/source/detail?r=21339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M src/mirror-debugger.js View 4 chunks +23 lines, -13 lines 0 comments Download
M src/promise.js View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/es6/mirror-promises.js View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
This CL is dependent on https://codereview.chromium.org/273653007/ What this changes: - circumvent cross context access checks ...
6 years, 7 months ago (2014-05-15 13:56:00 UTC) #1
Alexandra Mikhaylova
On 2014/05/15 13:56:00, Yang wrote: > This CL is dependent on https://codereview.chromium.org/273653007/ > > What ...
6 years, 7 months ago (2014-05-15 14:25:49 UTC) #2
Yang
On 2014/05/15 14:25:49, Alexandra Mikhaylova wrote: > On 2014/05/15 13:56:00, Yang wrote: > > This ...
6 years, 7 months ago (2014-05-15 14:26:33 UTC) #3
Alexandra Mikhaylova
On 2014/05/15 14:26:33, Yang wrote: > On 2014/05/15 14:25:49, Alexandra Mikhaylova wrote: > > On ...
6 years, 7 months ago (2014-05-16 11:30:35 UTC) #4
aandrey
lgtm
6 years, 7 months ago (2014-05-16 11:55:40 UTC) #5
Yang
6 years, 7 months ago (2014-05-16 13:06:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r21339 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698