Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 283363006: You should be able to deselect the only user pod in the desktop user manager. (Closed)

Created:
6 years, 7 months ago by noms (inactive)
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

You should be able to deselect the only user pod in the desktop user manager. BUG=371005 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272271

Patch Set 1 : #

Patch Set 2 : fix leftover rename. reading bot errors helps >.< #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/login/user_pod_row.js View 1 7 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
noms (inactive)
6 years, 7 months ago (2014-05-16 19:45:34 UTC) #1
Nikita (slow)
lgtm
6 years, 7 months ago (2014-05-16 19:52:22 UTC) #2
noms (inactive)
Wooo thanks for the quick review! :) On 2014/05/16 19:52:22, Nikita Kostylev wrote: > lgtm
6 years, 7 months ago (2014-05-16 19:53:05 UTC) #3
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 7 months ago (2014-05-20 19:32:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/283363006/20001
6 years, 7 months ago (2014-05-20 19:33:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 20:41:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 21:53:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29094)
6 years, 7 months ago (2014-05-20 21:53:56 UTC) #8
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 7 months ago (2014-05-20 21:55:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/283363006/20001
6 years, 7 months ago (2014-05-20 21:55:54 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 23:10:40 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 00:12:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29195)
6 years, 7 months ago (2014-05-21 00:12:07 UTC) #13
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 7 months ago (2014-05-21 17:46:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/283363006/20001
6 years, 7 months ago (2014-05-21 19:57:08 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 21:37:06 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 23:08:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29670)
6 years, 7 months ago (2014-05-21 23:08:59 UTC) #18
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 7 months ago (2014-05-22 12:08:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/283363006/20001
6 years, 7 months ago (2014-05-22 12:09:36 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 13:26:04 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 14:36:35 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29957)
6 years, 7 months ago (2014-05-22 14:36:35 UTC) #23
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 7 months ago (2014-05-22 14:47:59 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/283363006/40001
6 years, 7 months ago (2014-05-22 14:49:12 UTC) #25
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 19:31:21 UTC) #26
Message was sent while issue was closed.
Change committed as 272271

Powered by Google App Engine
This is Rietveld 408576698