Hide context menu on 'touchstart' event.

Hide context menu on 'touchstart' event.

When a user do non-Tap (e.g. LongPress for drag, LongTap for context menu) operations on touch panel, 'mousedown' is not dispatched immediately.
In these cases, context menu should be hided because user doesn't focus on the context menu anymore.
This CL hide the menu on 'touchstart' in the same manner as 'mousedown'.

BUG=267211
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270996

[fukino, 2014-05-15 11:08:15]

Hi @arv, could you take a look?

[arv (Not doing code reviews), 2014-05-15 19:24:25]

LGTM

[fukino, 2014-05-16 01:06:19]

On 2014/05/15 19:24:25, arv wrote:
> LGTM

Thanks!

[fukino, 2014-05-16 01:06:26]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-05-16 01:08:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/283363002/1

[commit-bot: I haz the power, 2014-05-16 06:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 06:10:47]

Failed to apply patch for
@master/ui/webui/resources/js/cr/ui/context_menu_handler.js:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/ui/webui/resources/js/cr/ui/context_menu_handler.js
Index: ui/webui/resources/js/cr/ui/context_menu_handler.js
diff --git @master/ui/webui/resources/js/cr/ui/context_menu_handler.js
@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
index
1a23019c05408799c0ccb1bc3f86bf91961f16ff..fd9b183b341a0ce2aaeb15e798a5d0297e597081
100644
--- a/@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
+++ b/@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
@@ -50,6 +50,7 @@ cr.define('cr.ui', function() {
       var win = doc.defaultView;
       this.showingEvents_.add(doc, 'keydown', this, true);
       this.showingEvents_.add(doc, 'mousedown', this, true);
+      this.showingEvents_.add(doc, 'touchstart', this, true);
       this.showingEvents_.add(doc, 'focus', this);
       this.showingEvents_.add(win, 'popstate', this);
       this.showingEvents_.add(win, 'resize', this);
@@ -150,6 +151,7 @@ cr.define('cr.ui', function() {
 
       switch (e.type) {
         case 'mousedown':
+        case 'touchstart':
           if (!this.menu.contains(e.target))
             this.hideMenu();
           else

[fukino, 2014-05-16 07:20:18]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-05-16 07:20:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/283363002/1

[commit-bot: I haz the power, 2014-05-16 07:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 07:55:09]

Failed to apply patch for
@master/ui/webui/resources/js/cr/ui/context_menu_handler.js:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/ui/webui/resources/js/cr/ui/context_menu_handler.js
Index: ui/webui/resources/js/cr/ui/context_menu_handler.js
diff --git @master/ui/webui/resources/js/cr/ui/context_menu_handler.js
@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
index
1a23019c05408799c0ccb1bc3f86bf91961f16ff..fd9b183b341a0ce2aaeb15e798a5d0297e597081
100644
--- a/@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
+++ b/@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
@@ -50,6 +50,7 @@ cr.define('cr.ui', function() {
       var win = doc.defaultView;
       this.showingEvents_.add(doc, 'keydown', this, true);
       this.showingEvents_.add(doc, 'mousedown', this, true);
+      this.showingEvents_.add(doc, 'touchstart', this, true);
       this.showingEvents_.add(doc, 'focus', this);
       this.showingEvents_.add(win, 'popstate', this);
       this.showingEvents_.add(win, 'resize', this);
@@ -150,6 +151,7 @@ cr.define('cr.ui', function() {
 
       switch (e.type) {
         case 'mousedown':
+        case 'touchstart':
           if (!this.menu.contains(e.target))
             this.hideMenu();
           else

[fukino, 2014-05-16 08:34:18]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-05-16 08:34:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/283363002/20001

[commit-bot: I haz the power, 2014-05-16 10:30:25]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-16 11:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:38:06]

Failed to apply patch for
@master/ui/webui/resources/js/cr/ui/context_menu_handler.js:
While running svn add @master --force --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  svn: '@master' is just a peg revision. Maybe try '@master@' instead?

Patch:       @master/ui/webui/resources/js/cr/ui/context_menu_handler.js
Index: ui/webui/resources/js/cr/ui/context_menu_handler.js
diff --git @master/ui/webui/resources/js/cr/ui/context_menu_handler.js
@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
index
1a23019c05408799c0ccb1bc3f86bf91961f16ff..fd9b183b341a0ce2aaeb15e798a5d0297e597081
100644
--- a/@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
+++ b/@master/ui/webui/resources/js/cr/ui/context_menu_handler.js
@@ -50,6 +50,7 @@ cr.define('cr.ui', function() {
       var win = doc.defaultView;
       this.showingEvents_.add(doc, 'keydown', this, true);
       this.showingEvents_.add(doc, 'mousedown', this, true);
+      this.showingEvents_.add(doc, 'touchstart', this, true);
       this.showingEvents_.add(doc, 'focus', this);
       this.showingEvents_.add(win, 'popstate', this);
       this.showingEvents_.add(win, 'resize', this);
@@ -150,6 +151,7 @@ cr.define('cr.ui', function() {
 
       switch (e.type) {
         case 'mousedown':
+        case 'touchstart':
           if (!this.menu.contains(e.target))
             this.hideMenu();
           else

[Paweł Hajdan Jr., 2014-05-16 11:50:00]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-16 11:50:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/283363002/20001

[commit-bot: I haz the power, 2014-05-16 11:52:12]

Change committed as 270996