Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: cc/output/begin_frame_args.h

Issue 2833603002: Revert of Plumb activation time to main (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/begin_frame_args.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/begin_frame_args.h
diff --git a/cc/output/begin_frame_args.h b/cc/output/begin_frame_args.h
index d41b2c8defeb7f50ce9838a959921a05f849532a..d4ced74a32c9bac8c462864f32e6b815151b8962 100644
--- a/cc/output/begin_frame_args.h
+++ b/cc/output/begin_frame_args.h
@@ -59,11 +59,8 @@
static constexpr uint64_t kInvalidFrameNumber = 0;
static constexpr uint64_t kStartingFrameNumber = 1;
- static constexpr uint32_t kDefaultSourceFrameNumber = 0;
-
// Creates an invalid set of values.
BeginFrameArgs();
- ~BeginFrameArgs();
#ifdef NDEBUG
typedef const void* CreationLocation;
@@ -78,12 +75,10 @@
static BeginFrameArgs Create(CreationLocation location,
uint32_t source_id,
uint64_t sequence_number,
- uint32_t source_frame_number,
base::TimeTicks frame_time,
base::TimeTicks deadline,
base::TimeDelta interval,
BeginFrameArgsType type);
- BeginFrameArgs(const BeginFrameArgs&);
// This is the default delta that will be used to adjust the deadline when
// proper draw-time estimations are not yet available.
@@ -109,26 +104,12 @@
uint64_t sequence_number;
uint32_t source_id; // |source_id| after |sequence_number| for packing.
- // |source_frame_number| is set by the LayerTreeHost when the BeginFrame
- // reaches blink and corresponds to the commit count.
- uint32_t source_frame_number;
-
- // This is to report Activation (ReadyToActivate signal) time back to main.
- // A vector of pairs of source_frame_number and timestamp is captured, and
- // sent back with the next ProxyMain::BeginMainFrame, and from there routed to
- // the Blink Scheduler. A vector is needed as there can be multiple
- // ReadyToActivate signals before the next BeginMainFrame.
- // TODO(panicker): Sub-class BeginFrameArgs as BeginMainFrameArgs and move
- // this there.
- std::vector<std::pair<uint32_t, base::TimeTicks>> ready_to_activate_time;
-
BeginFrameArgsType type;
bool on_critical_path;
private:
BeginFrameArgs(uint32_t source_id,
uint64_t sequence_number,
- uint32_t source_frame_number,
base::TimeTicks frame_time,
base::TimeTicks deadline,
base::TimeDelta interval,
« no previous file with comments | « no previous file | cc/output/begin_frame_args.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698