Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 2833583003: DevTools: proper management of ResourceTreeModel in NetworkProject (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
index 1666aee502f4572b43883777869beb07b5300ff9..5e7fd16520220208d9cdd2f1521df10174a6c1f5 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
@@ -28,9 +28,6 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-/**
- * @unrestricted
- */
SDK.ResourceTreeModel = class extends SDK.SDKModel {
/**
* @param {!SDK.Target} target
@@ -44,18 +41,22 @@ SDK.ResourceTreeModel = class extends SDK.SDKModel {
networkManager.addEventListener(
SDK.NetworkManager.Events.RequestUpdateDropped, this._onRequestUpdateDropped, this);
}
-
this._agent = target.pageAgent();
this._agent.enable();
this._securityOriginManager = target.model(SDK.SecurityOriginManager);
- this._fetchResourceTree();
-
target.registerPageDispatcher(new SDK.PageDispatcher(this));
+ /** @type {!Map<string, !SDK.ResourceTreeFrame>} */
+ this._frames = new Map();
+ this._cachedResourcesProcessed = false;
this._pendingReloadOptions = null;
this._reloadSuspensionCount = 0;
this._isInterstitialShowing = false;
+ /** @type {?SDK.ResourceTreeFrame} */
+ this.mainFrame = null;
+
+ this._agent.getResourceTree(this._processCachedResources.bind(this));
}
/**
@@ -100,13 +101,6 @@ SDK.ResourceTreeModel = class extends SDK.SDKModel {
return /** @type {!SDK.DOMModel} */ (this.target().model(SDK.DOMModel));
}
- _fetchResourceTree() {
- /** @type {!Map<string, !SDK.ResourceTreeFrame>} */
- this._frames = new Map();
- this._cachedResourcesProcessed = false;
- this._agent.getResourceTree(this._processCachedResources.bind(this));
- }
-
_processCachedResources(error, mainFramePayload) {
if (!error) {
this.dispatchEventToListeners(SDK.ResourceTreeModel.Events.WillLoadCachedResources);
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698