DevTools: proper management of ResourceTreeModel in NetworkProject

third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Index: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
index 1666aee502f4572b43883777869beb07b5300ff9..feb81e71e442cb269304ea598b3371d4d5a18062 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
@@ -28,9 +28,6 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-/**
- * @unrestricted
- */
 SDK.ResourceTreeModel = class extends SDK.SDKModel {
   /**
    * @param {!SDK.Target} target
@@ -44,18 +41,21 @@ SDK.ResourceTreeModel = class extends SDK.SDKModel {
       networkManager.addEventListener(
           SDK.NetworkManager.Events.RequestUpdateDropped, this._onRequestUpdateDropped, this);
     }
-
     this._agent = target.pageAgent();
     this._agent.enable();
     this._securityOriginManager = target.model(SDK.SecurityOriginManager);
 
-    this._fetchResourceTree();
-
     target.registerPageDispatcher(new SDK.PageDispatcher(this));
 
+    /** @type {!Map<string, !SDK.ResourceTreeFrame>} */
+    this._frames = new Map();
+    this._cachedResourcesProcessed = false;
     this._pendingReloadOptions = null;
     this._reloadSuspensionCount = 0;
     this._isInterstitialShowing = false;
+    this.mainFrame = null;

[dgozman, 2017/05/05 21:20:29]

/** @type {?...} */

[lushnikov, 2017/05/05 21:54:35]

Done.

+
+    this._fetchResourceTree();
   }
 
   /**
@@ -101,7 +101,6 @@ SDK.ResourceTreeModel = class extends SDK.SDKModel {
   }
 
   _fetchResourceTree() {

[dgozman, 2017/05/05 21:20:29]

Let's inline this.

[lushnikov, 2017/05/05 21:54:35]

Done.

-    /** @type {!Map<string, !SDK.ResourceTreeFrame>} */
     this._frames = new Map();
     this._cachedResourcesProcessed = false;
     this._agent.getResourceTree(this._processCachedResources.bind(this));