Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2833563004: Add explicit return types to work around #29398. (Closed)

Created:
3 years, 8 months ago by Paul Berry
Modified:
3 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add explicit return types to work around #29398. In a future CL I need to add an import to this file, and for reasons I haven't been able to track down, doing so causes type inference failures. This CL works around the problem by making the affected types explicit. Once the bug is fixed, I hope to be able to revert this. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/b5c6053debe19699b1feb2167535c3e1f138e304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -33 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 13 chunks +39 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 8 months ago (2017-04-20 04:38:46 UTC) #2
ahe
lgtm FWIW, I find it much easier to read when function signatures are fully typed, ...
3 years, 8 months ago (2017-04-20 07:54:58 UTC) #3
Paul Berry
3 years, 8 months ago (2017-04-20 08:29:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5c6053debe19699b1feb2167535c3e1f138e304 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698