Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: components/data_reduction_proxy/proto/pageload_metrics.proto

Issue 2833523002: Adding opt out and previews type information to DRP pingback (Closed)
Patch Set: bengr comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/proto/pageload_metrics.proto
diff --git a/components/data_reduction_proxy/proto/pageload_metrics.proto b/components/data_reduction_proxy/proto/pageload_metrics.proto
index ca26f3800fc1b26f1983a129aa5570f46ad05aa2..1725604afaef25d3097ed64780dd64c7ea059698 100644
--- a/components/data_reduction_proxy/proto/pageload_metrics.proto
+++ b/components/data_reduction_proxy/proto/pageload_metrics.proto
@@ -34,6 +34,26 @@ message PageloadMetrics {
EFFECTIVE_CONNECTION_TYPE_4G = 5;
};
+ // The various opt out states seen by server previews.
+ enum PreviewsOptOut {
+ // Set for non-previews navigations and app background navigations.
+ UNKNOWN = 0;
+ // Set for previews navigations that clicked "show original".
+ OPT_OUT = 1;
+ // Set for previews navigations that did not click "show original".
+ NON_OPT_OUT = 2;
+ }
+
+ // The various server previews that can be shown.
+ enum PreviewsType {
+ // No server preview was applied.
+ NONE = 0;
+ // Image placeholders were used on the page.
+ LOFI = 1;
+ // The main resource was a lite page.
+ LITE_PAGE = 2;
+ }
+
// The session key used to load the page.
optional string session_key = 1;
// The time at which the first request of the pageload was made, according to
@@ -75,4 +95,10 @@ message PageloadMetrics {
// The unique identifier for the page load.
optional uint64 page_id = 16;
+
+ // The opt out state of the page load.
+ optional PreviewsOptOut previews_opt_out = 17;
+
+ // The previews type that was used on the page.
+ optional PreviewsType previews_type = 18;
}
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698