Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2202)

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Issue 2833523002: Adding opt out and previews type information to DRP pingback (Closed)
Patch Set: bengr comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
index 7e2822338f2249f28161de7ea7e196a842ccc9a7..3d222d7722c7e970d729478e0e3e617bc27e836b 100644
--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
@@ -155,8 +155,8 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
SimulateLoadedResource({false /* was_cached */,
1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
page_load_metrics::PageLoadTiming timing;
timing.navigation_start = base::Time::FromDoubleT(1);
@@ -167,12 +167,12 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
SimulateLoadedResource({false /* was_cached */,
1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
histogram_tester().ExpectTotalCount(
internal::kHistogramSubresourceFilterCount, 1);
@@ -250,8 +250,8 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
SimulateLoadedResource({false /* was_cached */,
1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
page_load_metrics::PageLoadTiming timing;
timing.navigation_start = base::Time::FromDoubleT(1);
@@ -262,12 +262,12 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
SimulateLoadedResource({false /* was_cached */,
1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
histogram_tester().ExpectTotalCount(
internal::kHistogramSubresourceFilterCount, 1);

Powered by Google App Engine
This is Rietveld 408576698