Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2833523002: Adding opt out and previews type information to DRP pingback (Closed)
Patch Set: bengr comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index ac8a004ccd3304f38f952e58057366f9c8b0e6de..db9a01caa0f514dc732175b0aacdafec18503b12 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -418,12 +418,12 @@ TEST_F(CorePageLoadMetricsObserverTest, Reload) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
- 0 /* original_network_content_length */},
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
- 1024 * 40 /* original_network_content_length */},
+ 1024 * 40 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */},
};
int64_t network_bytes = 0;
@@ -504,12 +504,12 @@ TEST_F(CorePageLoadMetricsObserverTest, ForwardBack) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
- 0 /* original_network_content_length */},
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
- 1024 * 40 /* original_network_content_length */},
+ 1024 * 40 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */},
};
int64_t network_bytes = 0;
@@ -584,17 +584,17 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
- 0 /* original_network_content_length */},
+ 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
- 1024 * 40 /* original_network_content_length */},
+ 1024 * 40 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */},
};
int64_t network_bytes = 0;
int64_t cache_bytes = 0;
- for (auto request : resources) {
+ for (const auto& request : resources) {
SimulateLoadedResource(request);
if (!request.was_cached) {
network_bytes += request.raw_body_bytes;

Powered by Google App Engine
This is Rietveld 408576698