components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc - Issue 2833523002: Adding opt out and previews type information to DRP pingback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

Issue 2833523002: Adding opt out and previews type information to DRP pingback (Closed)

Patch Set: fewer string copies and csharrison nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc ('K') | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h ('k') | components/data_reduction_proxy/proto/pageload_metrics.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

index 22a9b101b0b2665c95b8d4574497a1a3cee4271d..5b80985b68d36cb93527b8076e12bb710378adcb 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc

@@ -17,7 +17,8 @@ DataReductionProxyPageLoadTiming::DataReductionProxyPageLoadTiming(

parse_blocked_on_script_load_duration,

const base::Optional<base::TimeDelta>& parse_stop,

int64_t network_bytes,

- int64_t original_network_bytes)

+ int64_t original_network_bytes,

+ bool app_background_occured)

: navigation_start(navigation_start),

response_start(response_start),

load_event_start(load_event_start),

@@ -28,7 +29,8 @@ DataReductionProxyPageLoadTiming::DataReductionProxyPageLoadTiming(

parse_blocked_on_script_load_duration),

parse_stop(parse_stop),

network_bytes(network_bytes),

- original_network_bytes(original_network_bytes) {}

+ original_network_bytes(original_network_bytes),

+ app_background_occured(app_background_occured) {}

DataReductionProxyPageLoadTiming::DataReductionProxyPageLoadTiming(

const DataReductionProxyPageLoadTiming& other) = default;