Chromium Code Reviews| Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc |
| diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc |
| index ac8a004ccd3304f38f952e58057366f9c8b0e6de..ef376e191258b4d1604eb6dee35b7784cea87cae 100644 |
| --- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc |
| +++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc |
| @@ -418,12 +418,10 @@ TEST_F(CorePageLoadMetricsObserverTest, Reload) { |
| page_load_metrics::ExtraRequestInfo resources[] = { |
| // Cached request. |
| {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */, |
| - false /* data_reduction_proxy_used*/, |
| - 0 /* original_network_content_length */}, |
| + 0 /* original_network_content_length */, nullptr}, |
|
bengr
2017/04/20 23:19:36
Perhaps comment everywhere that this is d_r_p_data
RyanSturm
2017/04/21 16:25:04
Done.
|
| // Uncached non-proxied request. |
| {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */, |
| - false /* data_reduction_proxy_used*/, |
| - 1024 * 40 /* original_network_content_length */}, |
| + 1024 * 40 /* original_network_content_length */, nullptr}, |
| }; |
| int64_t network_bytes = 0; |
| @@ -504,12 +502,10 @@ TEST_F(CorePageLoadMetricsObserverTest, ForwardBack) { |
| page_load_metrics::ExtraRequestInfo resources[] = { |
| // Cached request. |
| {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */, |
| - false /* data_reduction_proxy_used*/, |
| - 0 /* original_network_content_length */}, |
| + 0 /* original_network_content_length */, nullptr}, |
| // Uncached non-proxied request. |
| {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */, |
| - false /* data_reduction_proxy_used*/, |
| - 1024 * 40 /* original_network_content_length */}, |
| + 1024 * 40 /* original_network_content_length */, nullptr}, |
| }; |
| int64_t network_bytes = 0; |
| @@ -584,17 +580,15 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) { |
| page_load_metrics::ExtraRequestInfo resources[] = { |
| // Cached request. |
| {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */, |
| - false /* data_reduction_proxy_used*/, |
| - 0 /* original_network_content_length */}, |
| + 0 /* original_network_content_length */, nullptr}, |
| // Uncached non-proxied request. |
| {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */, |
| - false /* data_reduction_proxy_used*/, |
| - 1024 * 40 /* original_network_content_length */}, |
| + 1024 * 40 /* original_network_content_length */, nullptr}, |
| }; |
| int64_t network_bytes = 0; |
| int64_t cache_bytes = 0; |
| - for (auto request : resources) { |
| + for (const auto& request : resources) { |
| SimulateLoadedResource(request); |
| if (!request.was_cached) { |
| network_bytes += request.raw_body_bytes; |