Adding opt out and previews type information to DRP pingback

chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
 
 namespace {
@@ skipping 124 matching lines @@
           .InMilliseconds(),
       1);
 
   histogram_tester().ExpectTotalCount(
       internal::kHistogramSubresourceFilterForegroundDuration, 1);
 }
 
 TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
   NavigateAndCommit(GURL(kDefaultTestUrl));
 
-  SimulateLoadedResource({false /* was_cached */,
-                          1024 * 40 /* raw_body_bytes */,
-                          false /* data_reduction_proxy_used */,
-                          0 /* original_network_content_length */});
+  SimulateLoadedResource(
+      {false /* was_cached */, 1024 * 40 /* raw_body_bytes */,
+       false /* data_reduction_proxy_used */, false /* was_lofi_response */,
+       0 /* original_network_content_length */});
 
   page_load_metrics::PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(1);
   page_load_metrics::PageLoadMetadata metadata;
   metadata.behavior_flags |=
       blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
   SimulateTimingAndMetadataUpdate(timing, metadata);
 
-  SimulateLoadedResource({false /* was_cached */,
-                          1024 * 20 /* raw_body_bytes */,
-                          false /* data_reduction_proxy_used */,
-                          0 /* original_network_content_length */});
+  SimulateLoadedResource(
+      {false /* was_cached */, 1024 * 20 /* raw_body_bytes */,
+       false /* data_reduction_proxy_used */, false /* was_lofi_response */,
+       0 /* original_network_content_length */});
 
   SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
                           false /* data_reduction_proxy_used */,
+                          false /* was_lofi_response */,
                           0 /* original_network_content_length */});
 
   histogram_tester().ExpectTotalCount(
       internal::kHistogramSubresourceFilterCount, 1);
 
   // Navigate away from the current page to force logging of request and byte
   // metrics.
   NavigateToUntrackedUrl();
 
   histogram_tester().ExpectTotalCount(
@@ skipping 56 matching lines @@
       internal::kHistogramSubresourceFilterNoMediaCacheBytes, 1);
   histogram_tester().ExpectBucketCount(
       internal::kHistogramSubresourceFilterNoMediaCacheBytes, 10, 1);
 }
 
 TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
   NavigateAndCommit(GURL(kDefaultTestUrl));
 
   SimulateMediaPlayed();
 
-  SimulateLoadedResource({false /* was_cached */,
-                          1024 * 40 /* raw_body_bytes */,
-                          false /* data_reduction_proxy_used */,
-                          0 /* original_network_content_length */});
+  SimulateLoadedResource(
+      {false /* was_cached */, 1024 * 40 /* raw_body_bytes */,
+       false /* data_reduction_proxy_used */, false /* was_lofi_response */,
+       0 /* original_network_content_length */});
 
   page_load_metrics::PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(1);
   page_load_metrics::PageLoadMetadata metadata;
   metadata.behavior_flags |=
       blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
   SimulateTimingAndMetadataUpdate(timing, metadata);
 
-  SimulateLoadedResource({false /* was_cached */,
-                          1024 * 20 /* raw_body_bytes */,
-                          false /* data_reduction_proxy_used */,
-                          0 /* original_network_content_length */});
+  SimulateLoadedResource(
+      {false /* was_cached */, 1024 * 20 /* raw_body_bytes */,
+       false /* data_reduction_proxy_used */, false /* was_lofi_response */,
+       0 /* original_network_content_length */});
 
   SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
                           false /* data_reduction_proxy_used */,
+                          false /* was_lofi_response */,

[bengr, 2017/04/20 17:36:18]

Why no test coverage for was_lofi_response == true?

[RyanSturm, 2017/04/20 20:25:44]

Irrelevant and unused for this observer.

                           0 /* original_network_content_length */});
 
   histogram_tester().ExpectTotalCount(
       internal::kHistogramSubresourceFilterCount, 1);
 
   // Navigate away from the current page to force logging of request and byte
   // metrics.
   NavigateToUntrackedUrl();
 
   histogram_tester().ExpectTotalCount(
@@ skipping 50 matching lines @@
   histogram_tester().ExpectTotalCount(
       internal::kHistogramSubresourceFilterMediaNetworkBytes, 1);
   histogram_tester().ExpectBucketCount(
       internal::kHistogramSubresourceFilterMediaNetworkBytes, 60, 1);
 
   histogram_tester().ExpectTotalCount(
       internal::kHistogramSubresourceFilterMediaCacheBytes, 1);
   histogram_tester().ExpectBucketCount(
       internal::kHistogramSubresourceFilterMediaCacheBytes, 10, 1);
 }