Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2167)

Unified Diff: components/doodle/doodle_service.h

Issue 2833473002: Record NTP.LogoShownTime for timely refreshs only (Closed)
Patch Set: Replace |Refresh| return value with treib@'s revalidation event Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/doodle/doodle_service.h
diff --git a/components/doodle/doodle_service.h b/components/doodle/doodle_service.h
index e4a9792a99149bad9e08cf054aad14232881ae96..6d3572386eedb68701789fac7eb9734c4f8a0abd 100644
--- a/components/doodle/doodle_service.h
+++ b/components/doodle/doodle_service.h
@@ -27,6 +27,7 @@ class DoodleService : public KeyedService {
public:
class Observer {
public:
+ virtual void OnDoodleConfigRevalidated(bool from_cache) = 0;
virtual void OnDoodleConfigUpdated(const base::Optional<DoodleConfig>&) = 0;
};
@@ -57,8 +58,8 @@ class DoodleService : public KeyedService {
void RemoveObserver(Observer* observer);
// Requests an asynchronous refresh of the DoodleConfig from the network.
- // After the update completes, the observers will be notified only if the
- // config changed.
+ // After the update completes, the observers will be notified whether the
+ // config changes or active configs remain valid.
Marc Treib 2017/04/27 15:22:55 s/changes/changed/ s/active configs remain/the act
fhorschig 2017/04/28 08:20:07 Done.
void Refresh();
private:

Powered by Google App Engine
This is Rietveld 408576698